eclipse-tractusx / digital-product-pass

digital product pass
https://github.com/eclipse-tractusx/digital-product-pass
Apache License 2.0
21 stars 11 forks source link

Feature/simple wallet: DPP Verification Simple Wallet Component #343

Closed matbmoser closed 1 day ago

matbmoser commented 1 week ago

Why we create this PR?

For executing the PoC of this feature https://github.com/eclipse-tractusx/sig-release/issues/655, it was needed a simple wallet that is able to sign credentials and verify them too. It should manage the credentials.

What we want to achieve with this PR?

Have a simple wallet that can:

What is new?

Added

PR Linked to:

https://github.com/eclipse-tractusx/sig-release/issues/655

matbmoser commented 1 week ago

I dont know why it removed this parts License and Security, I will re-add it

matbmoser commented 1 week ago

All the code was done by me and worked by me before here: https://github.com/matbmoser/simple-wallet and now in Tractus-X. So no IP checks are needed

matbmoser commented 6 days ago

Ok solve the workflow things you told me Question the ingress things are not going to be solved when merged? Maybe we need to merge main on this branch so it gets the latest changes.

matbmoser commented 6 days ago

Ok @saudkhan116 I removed the ingress change so in the latest version with the ingress fixed there will be what you have already done.

saudkhan116 commented 3 days ago

@matbmoser, as per our discussion, we are now aligned and agreed on the copyright license headers. We will still use date range (creation date and the last updated date) to a changed file. Secondly, we make a separate copyright line for each company/code owner where applicable.

Example:

Copyright (c) 2022, 2024 BMW AG Copyright (c) 2022, 2024 Henkel AG & Co. KGaA Copyright (c) 2023, 2024 CGI Deutschland B.V. & Co. KG Copyright (c) 2023, 2024 Contributors to the Eclipse Foundation ...

DPP-verification: Copyright (c) 2023, 2024 BMW AG Copyright (c) 2023, 2024 CGI Deutschland B.V. & Co. KG Copyright (c) 2024 Contributors to the Eclipse Foundation ...

matbmoser commented 2 days ago

There was a bug in the "expiration date" check. Now its fixed

matbmoser commented 1 day ago

I needed to fix the chart version