eclipse-tractusx / digital-product-pass

Eclipse Tractus-X Digital Product Pass - An application for visualizing Digital Product Passports, Battery Passports and Transmission Passports, it is the reference implementation of the EcoPass KIT
https://github.com/eclipse-tractusx/digital-product-pass
Apache License 2.0
24 stars 15 forks source link

[DPP] [TRGs] QG 4 checks (Release 24.08) #365

Closed saudkhan116 closed 3 months ago

saudkhan116 commented 3 months ago

QG checks

Please open and fill in this issue in your product repository to document the compliance with our Tractus-X Release Guideline (TRGs)

Show compliance with TRGs by referencing to a tagged link in the respective repository where possible, example: TRG 1.01 (see github.com/eclipse-tractusx/example-repo/tree/1.0.0/README.md)

Close this issue once the compliance with the TRGs has been documented

Committer(s): @saudkhan116 , @matbmoser Helm Chart Version: 4.0.1 App Version: v4.0.1

Release Management Reference Issue: https://github.com/eclipse-tractusx/sig-release/issues/748

Check of Tractus-X Release Guidelines

TRG 1 Documentation

TRG 2 Git

TRG 3 Kubernetes

TRG 4 Container

TRG 5 Helm

TRG 6 Released Helm Chart

TRG 7 Open Source Governance

TRG 8 Security

Hints

Information Sharing

evegufy commented 3 months ago

Hi @saudkhan116 there was the following change to the issues template https://github.com/eclipse-tractusx/.github/pull/26/files, please take that change still into account for R24.08

saudkhan116 commented 3 months ago

Hi @saudkhan116 there was the following change to the issues template https://github.com/eclipse-tractusx/.github/pull/26/files, please take that change still into account for R24.08

Hi @evegufy I updated the content accordingly, thanks. However, I found that one of the TRG.5.05 is still not listed in the checklist. May I ask why it is not added in the template ?

matbmoser commented 3 months ago

What is the status of this checks @saudkhan116 ?

saudkhan116 commented 3 months ago

What is the status of this checks @saudkhan116 ?

@matbmoser, the changes from the template has been applied already. Once we have a stable release version, we can start the QG process. Right now no further action is required!

matbmoser commented 3 months ago

Ok I have revised the TRGs for the DPP, and for me everthing looks in order. Since we already released in R24.05 and not much things changed it can be already closed. There is just one that I could not check and is the "kit" documentation, because we are no KIT, however everything that is with documentation like the "dpp-verification" add-on uses the guidelines of the KITs, usage of "license" files for images, "CC-BY-4.0" notice in the footer is correct, and also all the files have the "header" licenses.

matbmoser commented 3 months ago

The release v4.0.1 should contain all the requirements, I have also checked for security and we are good

matbmoser commented 3 months ago

For me this is approved!

saudkhan116 commented 3 months ago

Cross checked by second committer: As we are not a KIT, the [TRG-7.07] (ttps://eclipse-tractusx.github.io/docs/release/trg-7/trg-7-07) is not applicable to this repo. LGTM, Approved!

matbmoser commented 3 months ago

Approved for this version: https://github.com/eclipse-tractusx/digital-product-pass/releases/tag/v4.0.1