eclipse-tractusx / eclipse-tractusx.github.io

https://eclipse-tractusx.github.io/
Apache License 2.0
29 stars 87 forks source link

chore(ecopass): fixed broken images bug in images svgs in compilation #934

Closed matbmoser closed 3 months ago

matbmoser commented 3 months ago

Description

There was a bug that was reported theissue below where broken images "svgs" were not possible to be compiled.

closes #930

What has changed?

Issues Fixed

Deleted

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

matbmoser commented 3 months ago

I dont know why but since I have sanitized the SVG I can not edit it with draw.io

matbmoser commented 3 months ago

No dependency was added just cloned from main

matbmoser commented 3 months ago

I dont know why but since I have sanitized the SVG I can not edit it with draw.io

Ok this was fixed

matbmoser commented 3 months ago

Thank you @arnoweiss for the support in solving the Dependency problem. I was thinking that the dash dependencies were updated with the 3rd party dependency pipeline automatically.

matbmoser commented 3 months ago

@arnoweiss there was a problem with the formating from the SVG files. I solved by recreating the images again in draw.io. Some of them probably is a export problem, people need to export the svgs correctly in Draw.io. Not "save as SVG" but "export as SVG"