Closed LuisRickert closed 1 year ago
@matbmoser @AngelikaWittek please review,should be now compliant
I reviewed the changes from a TRG compliance for me its ok, just would like to get the approval from @AngelikaWittek if you can be so kind.
Now from a content perpective, for a initial version is ok for me however there are some things I would change:
Please update this diagram in next versions: https://github.com/LuisRickert/eco-pass-kit-fork/blob/chore/setup-repo/docs/resources/development-view/adoption-view-EcoPassKIT_IT_Arch.png -> Check the new Arc42: https://github.com/eclipse-tractusx/digital-product-pass/blob/main/docs/arc42/ContextDiagram.jpeg
Now the new architecture includes BPN Discovery, EDC Disocvery etc
Some images are also in not good size they are too litle to visualize in github:
Thanks for your review, I'll get the updates.
First of all, thank you for the awesome Job! 💯 🥇 🎉
I revised in deep the TRGs to see if you forgot something.
@LuisRickert because is the first contribution there is some things that are still missing.
However just add/fix this little things and I can approve the PR. Please just note that I am having conflicts to merge the files please resolve them also so that I can merge it. Otherwise I will need to solve them by my self in your fork...
formal requirements:
.tractucsx
with thisdependency
filecontent review:
edit: typo
@matbmoser finally 😄 done ✅
With this PR we move the ECO-Pass KIT Documentation to the dedicated Tractus-X Repository.
ToDos: