eclipse-tractusx / item-relationship-service

https://eclipse-tractusx.github.io/item-relationship-service/docs/
Apache License 2.0
7 stars 21 forks source link

Remove Product-Lock KeyCloack from Documentation and HelmCharts #201

Closed jzbmw closed 9 months ago

jzbmw commented 10 months ago

As we are using OAuth2 Standard to authorize IRS and the API we have actually a product-lock in the configuration, documentation and in helm charts configuration. This might be removed to have a more generic approach.

Hints / Details

Current

keycloak:
  oauth2:
    clientId: <keycloak-client-id>
    clientSecret: <keycloak-client-secret>
    clientTokenUri: <keycloak-token-uri>
    jwkSetUri: <keycloak-jwkset-uri>

Expected

oauth2:
  clientId: "" #<oauth2.clientId>
  clientSecret: "" #<oauth2.clientSecret>
  clientTokenUri: "" #<oauth2.clientTokenUri>
  jwkSetUri: "" #<oauth2.jwkSetUri>
  resourceClient: "" #<oauth2.resourceClient>

Tasks

Outcome / Acceptance Criteria

Outcome

Out of Scope

Sprint Planning 2

Currently

 clientId: <path:traceability-irs/data/dev/keycloak/oauth2#clientId>
      clientSecret: <path:traceability-irs/data/dev/keycloak/oauth2#clientSecret>
      clientTokenUri: <path:traceability-irs/data/dev/keycloak/oauth2#tokenUri>
      jwkSetUri: <path:traceability-irs/data/dev/keycloak/oauth2#jwkSetUri>

Expected

 clientId: <path:traceability-irs/data/dev/oauth2#clientId>
      clientSecret: <path:traceability-irs/data/dev/oauth2#clientSecret>
      clientTokenUri: <path:traceability-irs/data/dev/oauth2#tokenUri>
      jwkSetUri: <path:traceability-irs/data/dev/oauth2#jwkSetUri>
ds-ext-kmassalski commented 10 months ago

Waiting for: https://github.com/eclipse-tractusx/sig-infra/issues/342

mkanal commented 10 months ago

Hi @ds-ext-kmassalski & @ds-alexander-bulgakov
what is missing is the outcome. Was this tested. How could this be tested? Is there some evidence to check? Need some assistance here. Thank you very much,

ds-alexander-bulgakov commented 10 months ago

Hi @ds-ext-kmassalski, as discussed please make sure the changes are deployt on DEV so i can test. Please give me a hint once the deployment is done. Thank you!

ds-ext-kmassalski commented 10 months ago

Updated documentation without any 'Keycloak' mentions can be found here: https://catenax-ng.github.io/tx-item-relationship-service/docs/arc42/full.html OAuth2 protocol is used as substitute.

ds-ext-kmassalski commented 10 months ago

App deployed on DEV and INT with newest version (without keycloak configuration names).

Some more evidences that its was modified:

image

image

image

ds-alexander-bulgakov commented 9 months ago

No issues could be found during final QA-review. For testing tavern and cucumber tests were run in gitlab and locally and IRS-jobs were requested on DEV. Docu was checked as well. See outcome:

Ticket is ready for PO-review. FYI @jzbmw