eclipse-tractusx / item-relationship-service

https://eclipse-tractusx.github.io/item-relationship-service/docs/
Apache License 2.0
7 stars 21 forks source link

Refactor API Documentation to not contain duplicated values in arrays #241

Closed jzbmw closed 6 months ago

jzbmw commented 10 months ago

As Developer, I want to be able to understand the API and don't have duplicated values in arrays so that it is clear what to implement.

Hints / Details

Feature:

Acceptance Criteria

Out of Scope

ds-psosnowski commented 6 months ago

Planning 2: Task itself is tricky since we need to match with api generated by open-api and when doing so, open-api generates 5 items each as an example for static docs (available without running an application). There are 2 possible solutions

  1. add examples to whole structures in both documentations, not in declarative way, for example:

    example: 
    {
    "example": {
    "example": "example"
    }
    }

    instead of

    example:
    example:
    example
  2. Or just try to match contract precisely with examples and declarations in open-api.yaml with examples specially prepared for arrays (this didn't seemed to work every time but need to be checked).

ds-psosnowski commented 6 months ago

PR: https://github.com/catenax-ng/tx-item-relationship-service/pull/813

ds-psosnowski commented 6 months ago

@mkanal story is ready for review docs can be found here: https://catenax-ng.github.io/tx-item-relationship-service/docs/api-specification/api-specification.html

mkanal commented 6 months ago

image

mkanal commented 6 months ago

@jzbmw LGFM subjectId was incorrect and now it is according to AAS specification. Ready for PO review. https://catenax-ng.github.io/tx-item-relationship-service/docs/api-specification/api-specification.html#getBPNInvestigation