[ESS][SUPPLY-CHAIN_ACT] IRS ESS shows infected Supply-Chain on 1.(first) Tier Level

eclipse-tractusx / item-relationship-service

https://eclipse-tractusx.github.io/item-relationship-service/docs/

Apache License 2.0

7 stars 21 forks source link

[ESS][SUPPLY-CHAIN_ACT] IRS ESS shows infected Supply-Chain on 1.(first) Tier Level #244

Closed jzbmw closed 9 months ago

jzbmw commented 10 months ago

As user I want that the sub-tree where infection was found is known so that I am able to address the correct supplier for more investigation

Hints / Details

child of eclipse-tractusx/sig-release#213
https://confluence.catena-x.net/display/IRS/%5BTRI-1519%5D%5BTRI-1523%5D+IRS%3A+ESS+Top-Down+Use+Case

Outcome / Acceptance Criteria

Outcome

...
Acceptance Criteria
[x] ESS Job Response contains the sub-tree on first Tier level where infection was found
[x] The BPNL of Tier 1 Supplier is passed as impactedSupplierOnFirstTier.
[x] Final aggregation contains infected supply chain BPNL on first Tier level.

Out of Scope

ds-alexander-bulgakov commented 10 months ago

FYI I corrected the ESS testdatafile ESS_Testdata_v2.0.0-AsPlanned.json since the "Vehicle D" ids were not completely correct. Changes pushed to Pawels branch feature/TRI-1658-infected-supply-chain-on-first-tier-level. Please note the changes are not uploaded yet.

ds-alexander-bulgakov commented 10 months ago

Hi @ds-psosnowski! I was able to detect an issue for requests on first incident level. See e.g. request { "key": { "globalAssetId": "urn:uuid:3a2a1ca9-c6c1-49c7-a7ae-1dfc5fb9881f", "bpn": "BPNL00ARBITRARY8" }, "incidentBPNSs": ["BPNS0ARBITRARY10"], "bomLifecycle": "asPlanned" } which is expected to have the "bpnl" result "BPNS0ARBITRARY10" but is "BPNL00000004FAIL" instead:

Could you have a look please?

ds-alexander-bulgakov commented 10 months ago

Please also have a look on scenario with more then one node with affected BPN. E. for this request: { "key": { "globalAssetId": "urn:uuid:aad27ddb-43aa-4e42-98c2-01e529ef127c", "bpn": "BPNL00ARBITRARY1" }, "incidentBPNSs": ["BPNS00000003B6LU"], "bomLifecycle": "asPlanned" }

we are expecting two entries in the impactedSuppliersOnFirstTier array. Currently there is only one.

ds-alexander-bulgakov commented 9 months ago

No more issues could be found during testing on ESS-INT with branch feature/TRI-1658-infected-supply-chain-on-first-tier-level. The first tier level with infection is detected correctly, see e.g. request: { "key": { "globalAssetId": "urn:uuid:3a2a1ca9-c6c1-49c7-a7ae-1dfc5fb9881f", "bpn": "BPNL00ARBITRARY8" }, "incidentBPNSs": ["BPNS0ARBITRARY11"], "bomLifecycle": "asPlanned" } and impactedSupplierOnFirstTier result: "submodels": [ { "identification": null, "aspectType": "supply_chain_impacted", "payload": { "supplyChainImpacted": "Yes", "impactedSuppliersOnFirstTier": { "bpnl": "BPNL00ARBITRARY10", "hops": 2 }... Tavern tests have been added to same branch. This is the outcome:

ESS Job Response contains the sub-tree on first Tier level where infection was found.
The BPNL of Tier 1 Supplier is passed as impactedSupplierOnFirstTier.
Tavern tests have been implemented. See JIRA tickets TRI-1757, TRI-1758, TRI-1759 and TRI-1760.

Ticket is ready for PO-review. FYI @jzbmw