Update Testdata set with Industry Core 2.0.0 compatibility

mkanal commented 8 months ago

As team I want update to the latest test data set so that we are up-to-date

Link

https://github.com/eclipse-tractusx/item-relationship-service/issues/503

Hints / Details

https://jira.catena-x.net/browse/TDG-43
We already know that currently the tavern tests are failing regarding the SLBAB 3.0.0
Renaming will be clarified until 20th of march Replacing of Aspects
- SerialPart --> PartInstance
- PartAsPlaned -> PartType

SingleLevelBomAsBuilt version 3.0.0

{
"catenaXId" : "urn:uuid:055c1128-0375-47c8-98de-7cf802c3241d",
"childItems" : [ {
"catenaXId" : "urn:uuid:055c1128-0375-47c8-98de-7cf802c3241d",
"quantity" : {
  "quantityNumber" : 2.5,            <<<<
  "measurementUnit" : "unit:litre"    <<<<
},
"hasAlternatives" : true,
"createdOn" : "2022-02-03T14:48:54.709Z",
"businessPartner" : "BPNL50096894aNXY",
"lastModifiedOn" : "2022-02-03T14:48:54.709Z"
} ]
}

SingleLevelBomAsBuil version 3.0.0

{
  "catenaXId" : "urn:uuid:055c1128-0375-47c8-98de-7cf802c3241d",
  "childItems" : [ {
    "catenaXId" : "urn:uuid:055c1128-0375-47c8-98de-7cf802c3241d",
    "quantity" : {
      "value" : 20.0,      <<<<
      "unit" : "unit:piece" <<<<
    },
    "hasAlternatives" : false,
    "createdOn" : "2022-02-03T14:48:54.709Z",
    "businessPartner" : "BPNL50096894aNXY",
    "lastModifiedOn" : "2022-02-03T14:48:54.709Z"
  } ]
}

Acceptance Criteria

[x] Update to new test data set https://confluence.catena-x.net/download/attachments/98566737/CX_Testdata_v1.7.0_PartInstance.zip?version=1&modificationDate=1710484971972&api=v2
[x] Rename attributes within the "quantity" object marked with <<<< within the test data set
[x] Alter the version of SingleLevelBomAsBuilt to 3.0.0
- [x] Documentation
- [x] INT Tests
- [x] Tavern Test & Cucumber Test
- [x] All use cases

Out of Scope

...

ds-jhartmann commented 7 months ago

Planning 2:

prepare a reduced set of testdata 1.7.0
change SingleLevelBomAsBuilt from 2.0.0 to 3.0.0
upload to DEV

ds-jhartmann commented 7 months ago

@jzbmw According to https://github.com/eclipse-tractusx/item-relationship-service/issues/439, the tavern tests are supposed to be updated with this issue. We did not account for that in the refinement or planning.

Can we clarify how to deal with this in the next daily?

dsmf commented 7 months ago

blocks #357

ds-ext-kmassalski commented 7 months ago

DONE - prepare a reduced set of testdata 1.7.0
DONE - change SingleLevelBomAsBuilt from 2.0.0 to 3.0.0
DONE - upload to DEV
DONE - Update to new test data set https://confluence.catena-x.net/download/attachments/98566737/CX_Testdata_v1.7.0_PartInstance.zip?version=1&modificationDate=1710484971972&api=v2
DONE - Rename attributes within the "quantity" object marked with <<<< within the test data set
DONE - Alter the version of SingleLevelBomAsBuilt to 3.0.0

1.7.0 is uploaded to DEV and Job can be registered:

{
    "aspects": [
        "urn:samm:io.catenax.single_level_bom_as_built:3.0.0#SingleLevelBomAsBuilt",
        "urn:samm:io.catenax.serial_part:3.0.0#SerialPart"
    ],
    "bomLifecycle": "asBuilt",
    "collectAspects": true,
    "lookupBPNs": false,
    "direction": "downward",
    "depth": 10,
    "key": {
        "globalAssetId": "urn:uuid:4235f1cf-d303-4b79-bdb1-7a31526bbabd",
        "bpn": "BPNL00000001CRHK"
    }
}

Job id: acb6a8c4-a7b5-4ce5-adea-81db30acc9da

Tavern tests will be fixed in scope of: https://github.com/eclipse-tractusx/item-relationship-service/issues/503

mkanal commented 7 months ago

DONE - prepare a reduced set of testdata 1.7.0

DONE - change SingleLevelBomAsBuilt from 2.0.0 to 3.0.0

DONE - upload to DEV

DONE - Update to new test data set https://confluence.catena-x.net/download/attachments/98566737/CX_Testdata_v1.7.0_PartInstance.zip?version=1&modificationDate=1710484971972&api=v2

DONE - Rename attributes within the "quantity" object marked with <<<< within the test data set

DONE - Alter the version of SingleLevelBomAsBuilt to 3.0.0

1.7.0 is uploaded to DEV and Job can be registered:
{
  "aspects": [
      "urn:samm:io.catenax.single_level_bom_as_built:3.0.0#SingleLevelBomAsBuilt",
      "urn:samm:io.catenax.serial_part:3.0.0#SerialPart"
  ],
  "bomLifecycle": "asBuilt",
  "collectAspects": true,
  "lookupBPNs": false,
  "direction": "downward",
  "depth": 10,
  "key": {
      "globalAssetId": "urn:uuid:4235f1cf-d303-4b79-bdb1-7a31526bbabd",
      "bpn": "BPNL00000001CRHK"
  }
}
Job id: acb6a8c4-a7b5-4ce5-adea-81db30acc9da

Tavern tests will be fixed in scope of: #503

BPNL00000001CRHK is incorrect -correct is BPNL00000003CSGV This test might not work.

mkanal commented 7 months ago

Test Outcome:

Validation for SLUAB 3.0.0 MUST fail as this does not fit the schema https://github.com/eclipse-tractusx/sldt-semantic-models/blob/main/io.catenax.single_level_usage_as_built/3.0.0/gen/SingleLevelUsageAsBuilt-schema.json
BPNL00000001CRHK is incorrect -correct is BPNL00000003CSGV This test might not work.

Please rework @ds-ext-kmassalski

ds-ext-kmassalski commented 7 months ago

@mkanal

"Validation for SLUAB 3.0.0 MUST fail as this does not fit the schema" - I prepared unit test where I reproduced this behavior and created a bug ticket for that: https://github.com/eclipse-tractusx/item-relationship-service/issues/522

Yesterday I uploaded newest datasets: https://github.com/catenax-ng/tx-item-relationship-service/blob/main/local/testing/testdata/CX_Testdata_v1.7.0_PartInstance-reduced.json

Example shell: urn:uuid:f719e96e-2d7a-4d25-b351-7ad81db4f12a + BPNL00000003AYRE

{
    "aspects": [
        "urn:samm:io.catenax.single_level_bom_as_built:3.0.0#SingleLevelBomAsBuilt"
    ],
    "bomLifecycle": "asBuilt",
    "collectAspects": true,
    "lookupBPNs": true,
    "direction": "downward",
    "depth": 10,
    "key": {
        "globalAssetId": "urn:uuid:f719e96e-2d7a-4d25-b351-7ad81db4f12a",
        "bpn": "BPNL00000003AYRE"
    }
}

Job ID: dcfde6fa-7653-40ed-9e9b-3cf31ec0cdde

Insomnia DEV env updated here: https://github.com/catenax-ng/tx-item-relationship-service/pull/856/files

mkanal commented 7 months ago

{ "aspects": [ "urn:samm:io.catenax.single_level_bom_as_built:3.0.0#SingleLevelBomAsBuilt", "urn:samm:io.catenax.serial_part:3.0.0#SerialPart", "urn:samm:io.catenax.just_in_sequencepart:3.0.0#JustInSequencePart", "urn:samm:io.catenax.batch:3.0.0#Batch" ], "key": { "globalAssetId": "{% prompt 'Global Asset ID', 'Please provide \'Global-Asset-ID\' or use default', .GLOBAL_ASSETID, '', false, true %}", "bpn": "{% prompt 'bpn', '', .BPN, '', false, true %}" }, "collectAspects": true }

{ "aspects": [ "urn:samm:io.catenax.serial_part:3.0.0#SerialPart", "urn:samm:io.catenax.single_level_bom_as_built:3.0.0#SingleLevelBomAsBuilt", "urn:samm:io.catenax.batch:3.0.0#Batch", "urn:samm:io.catenax.just_in_sequence_part:3.0.0#JustInSequencePart", "urn:bamm:io.catenax.battery.product_description:1.0.1#ProductDescription", "urn:bamm:io.catenax.material_for_recycling:1.1.0#MaterialForRecycling", "urn:bamm:io.catenax.traction_battery_code:1.0.0#TractionBatteryCode", "urn:bamm:io.catenax.part_asplanned:1.0.1#PartAsPlanned" ], "key": { "globalAssetId": "{% prompt 'Global Asset ID', 'Please provide \'Global-Asset-ID\' or use default', .GLOBAL_ASSETID, '', false, true %}", "bpn": "{% prompt 'bpn', '', .BPN, '', false, true %}" }, "collectAspects": true, "lookupBPNs": true }

mkanal commented 7 months ago

@jzbmw Retesting was successful works as indented. Kindly ask for PO acceptance.

eclipse-tractusx / item-relationship-service