search

eclipse-tractusx / item-relationship-service

https://eclipse-tractusx.github.io/item-relationship-service/docs/
Apache License 2.0
7 stars 19 forks source link

"/$value" for submodel URL is missing for 24.03 version of IRS #739

Open rogocof opened 1 week ago

rogocof commented 1 week ago

Description

Fetching of submodels is not working because the URL is built wrongly. We need to backport/cherry pick a bugfix for 24.03 (4.5.2) https://github.com/eclipse-tractusx/item-relationship-service/commit/cfc065c408534ef7eefd3652f82fd1a10b0ae867

Current behaviour

The issue is that the IRS does not append the “/$value” suffix to the URL like it is described in the standard

Expected behavior

Append the “/$value” suffix to the URL like in the Bugfix cfc065c408534ef7eefd3652f82fd1a10b0ae867

image

Steps to reproduce the Bug

Let IRS fetch any submodel and you will see that it tries to reach the URL without the suffix.

rogocof commented 1 week ago

@mkanal Please prioritize this bug.

@poojapatel23 will work on the fix during my absence in the next days

Questions to @ds-jhartmann:

  1. Against which branch should we create the PR?
  2. Is there a specific process to create the tag after the merge? Are we allowed/permitted to do that?
ds-jhartmann commented 1 week ago

@rogocof the branch should be created off of this tag https://github.com/eclipse-tractusx/item-relationship-service/tree/4.5.2

The release process is described here, but you require eclipse-committer status to create tags and merge PRs. I can do that once the changes are prepared

rogocof commented 1 week ago

Thanks @ds-jhartmann @poojapatel23 do you need more information to prepare the fix?