search

eclipse-tractusx / knowledge-agents

Reference Implementations of CX-0084 (Federated Queries In Data Spaces)
Apache License 2.0
0 stars 4 forks source link

feat: upgrade matchmaking agent to interact with edc 0.7; complete chart/deployment #120

Closed drcgjung closed 3 months ago

drcgjung commented 4 months ago

WHAT

The Matchmaking Agent is now able to interact with

WHY

The Matchmaking Agent has been carved out of Knowledge Agent Plane 1.11.16 (24.03) which run against TX EDC 0.5.* This PR contains the necessary adaptions and bugfixes following the 24.05 E2E Test phase.

FURTHER NOTES

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Closes #54 Closes #53

drcgjung commented 4 months ago

@almadigabor Here is the list of upgraded dependencies (Apache Jena -> 4.9.0) which may need an IP check

maven/mavencentral/org.apache.jena/jena-arq/4.9.0, Apache-2.0, restricted, clearlydefined maven/mavencentral/org.apache.jena/jena-base/4.9.0, Apache-2.0, restricted, clearlydefined maven/mavencentral/org.apache.jena/jena-core/4.9.0, Apache-2.0, restricted, clearlydefined maven/mavencentral/org.apache.jena/jena-dboe-base/4.9.0, Apache-2.0, restricted, clearlydefined maven/mavencentral/org.apache.jena/jena-dboe-index/4.9.0, Apache-2.0, restricted, clearlydefined maven/mavencentral/org.apache.jena/jena-dboe-storage/4.9.0, Apache-2.0, restricted, clearlydefined maven/mavencentral/org.apache.jena/jena-dboe-trans-data/4.9.0, Apache-2.0, restricted, clearlydefined maven/mavencentral/org.apache.jena/jena-dboe-transaction/4.9.0, Apache-2.0, restricted, clearlydefined maven/mavencentral/org.apache.jena/jena-fuseki-core/4.9.0, Apache-2.0, restricted, clearlydefined maven/mavencentral/org.apache.jena/jena-rdfconnection/4.9.0, Apache-2.0, restricted, clearlydefined maven/mavencentral/org.apache.jena/jena-rdfpatch/4.9.0, Apache-2.0, restricted, clearlydefined maven/mavencentral/org.apache.jena/jena-shacl/4.9.0, Apache-2.0, restricted, clearlydefined maven/mavencentral/org.apache.jena/jena-shex/4.9.0, Apache-2.0, restricted, clearlydefined maven/mavencentral/org.apache.jena/jena-tdb/4.9.0, Apache-2.0, restricted, clearlydefined maven/mavencentral/org.apache.jena/jena-tdb2/4.9.0, Apache-2.0, restricted, clearlydefined

Source Code and Deployment double-checked by Oz.

Would be great if you could review/commit this before the 15th of May (SAST check should run before the 17th Q-Gates)

almadigabor commented 4 months ago

Hi @drcgjung, I've ran the dash tool and got the following output:

[INFO] This content is either not correctly mapped by the system, or requires review.
[INFO] A review is required for maven/mavencentral/org.apache.jena/jena-rdfpatch/4.9.0.
[INFO] A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14714 .
[INFO] A review is required for maven/mavencentral/org.apache.jena/jena-core/4.9.0.
[INFO] A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14700 .
[INFO] A review is required for maven/mavencentral/org.apache.jena/jena-tdb2/4.9.0.
[INFO] A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14701 .
[INFO] A review is required for maven/mavencentral/org.apache.jena/jena-fuseki-core/4.9.0.
[INFO] A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14702 .
[INFO] A review is required for maven/mavencentral/org.apache.jena/jena-rdfconnection/4.9.0.
[INFO] A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14703 .
[INFO] A review is required for maven/mavencentral/org.apache.jena/jena-dboe-storage/4.9.0.
[INFO] A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14704 .
[INFO] A review is required for maven/mavencentral/org.apache.jena/jena-dboe-base/4.9.0.
[INFO] A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14705 .
[INFO] A review is required for maven/mavencentral/org.apache.jena/jena-shacl/4.9.0.
[INFO] A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14706 .
[INFO] A review is required for maven/mavencentral/org.apache.jena/jena-dboe-trans-data/4.9.0.
[INFO] A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14707 .
[INFO] A review is required for maven/mavencentral/org.apache.jena/jena-tdb/4.9.0.
[INFO] A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14708 .
[INFO] A review is required for maven/mavencentral/org.apache.jena/jena-shex/4.9.0.
[INFO] A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14709 .
[INFO] A review is required for maven/mavencentral/org.apache.jena/jena-dboe-index/4.9.0.
[INFO] A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14710 .
[INFO] A review is required for maven/mavencentral/org.apache.jena/jena-arq/4.9.0.
[INFO] A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14711 .
[INFO] A review is required for maven/mavencentral/org.apache.jena/jena-dboe-transaction/4.9.0.
[INFO] A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14712 .

Let's wait until the afternoon for these to be resolved then I can review and merge your PR. You might need a DEPENDENCIES file update once the IP issues are closed.

almadigabor commented 4 months ago

Hey @drcgjung, can you update the dependencies file? If I see it correctly, all issues have been approved.

drcgjung commented 4 months ago

Hey @drcgjung, can you update the dependencies file? If I see it correctly, all issues have been approved.

@almadigabor done and successful. thx.

almadigabor commented 4 months ago

I opened an IP review issue due to the large number of changes. Please track the status here.

drcgjung commented 4 months ago

actually the current lint test failure is a fluke: https://github.com/catenax-ng/tx-knowledge-agents/actions/runs/9110519613/job/25045730604 seems like some rare timing/kind issue occured - could not reproduce it. so maybe simply restart the failted check/job and it should go through.

almadigabor commented 3 months ago

The IP check issue have been approved.