fix(helm): remove Helm release v1.1.0

fty4 commented 9 months ago

Description

Removing invalid release inside repo index.

fixes #204

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

[x] DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
[x] Copyright and license header are present on all affected files

borisrizov-zf commented 9 months ago

@fty4 I believe the 1.1.0 version is already on the tractusx-dev repo, because I don't see it in the helm-charts directory. We'll have to remove it there too.

borisrizov-zf commented 9 months ago

@fty4 Did you manually remove the entry or did you run helm repo index helm-charts --url https://eclipse-tractusx.github.io/managed-identity-wallet/helm-charts?

fty4 commented 9 months ago

I manually removed the version and run the command afterwards - only had changes in the timestamp which I did not commit.

fty4 commented 9 months ago

@fty4 I believe the 1.1.0 version is already on the tractusx-dev repo, because I don't see it in the helm-charts directory. We'll have to remove it there too.

Which repo do you mean? In the download address it is pointing to some release: https://github.com/eclipse-tractusx/managed-identity-wallet/releases/download/managed-identity-wallet-1.1.0/managed-identity-wallet-1.1.0.tgz -> managed-identity-wallet-1.1.0 should this be removed?

borisrizov-zf commented 9 months ago

@fty4 I believe the 1.1.0 version is already on the tractusx-dev repo, because I don't see it in the helm-charts directory. We'll have to remove it there too.

Which repo do you mean? In the download address it is pointing to some release: https://github.com/eclipse-tractusx/managed-identity-wallet/releases/download/managed-identity-wallet-1.1.0/managed-identity-wallet-1.1.0.tgz -> managed-identity-wallet-1.1.0 should this be removed?

That should be removed as well. And the one on eclipse-tractusx.github.io too. Let's add a checklist to the summary so we can track everything that has to be removed.

borisrizov-zf commented 9 months ago

We'll be merging #208 and #209 first, afterwards we'll circle back to this.

SebastianBezold commented 9 months ago

To clarify our chart repo and publishing:

Most of our repos publish charts via chart-releaser-action
This packages the Helm Chart as .tgz and attaches it to a GitHub release, so it is downloadable
Additionally a index.yaml with info about all released charts is maintained in the gh-pages branch
Additionally to the stuff in a single repo, we do have a workflow, that is collection all of the index.yaml files from our repos and merges it to a single one in eclipse-tractusx/charts.
This is is done to have a single Chart repo, that one can use to install all of our Charts and not having to add every GitHub repo as Chart repo

So to completely remove all traces of a Chart, we need to:

delete the GitHub release containing the packaged Chart
remove the reference to it in the index.yaml in the product repo
remove the reference to it in the index.yaml in the eclipse-tractusx/charts repo

fty4 commented 9 months ago

So to completely remove all traces of a Chart, we need to:

delete the GitHub release containing the packaged Chart

remove the reference to it in the index.yaml in the product repo

remove the reference to it in the index.yaml in the eclipse-tractusx/charts repo

@SebastianBezold Totally agree with you here. I am not allowed to remove the release (point 1) but created this PR to remove the reference from the product repo (point 2). I would have submitted a PR after this one is merged anyway in order to fix the charts repo reference.

@borisrizov-zf I do not understand why we need to wait for those two PRs - could you give more insights here?

borisrizov-zf commented 9 months ago

@fty4 Yes, our pipeline creates automatic releases, which means we'll need to rebase branches which are being PRed. The two commits are tightly coupled and I want them to go through uninterrupted. #208 is now merge and #209 will follow shortly. After that you can rebase and we can merge this PR.

borisrizov-zf commented 9 months ago

@fty4 Hi, you can rebase and force push. I will merge this then.