eclipse-tractusx / managed-identity-wallet

Apache License 2.0
9 stars 22 forks source link

chore(helm)!: BREAKING CHANGE: bump postgresql version to 12.12.9 #236

Closed DominikPinsel closed 4 months ago

DominikPinsel commented 8 months ago

IMPORTANT

Upgrading the PostgreSQL version is a breaking change. I added a link to the official documentation in the commit message, which should become part of the change logs.

As it is a breaking change, the CI Pipeline for the chart upgrade can never run successful.

Description

Set PostgreSQL version to 12.12.9. See https://eclipse-tractusx.github.io/docs/release/trg-5/trg-5-07/

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@borisrizov-zf This PR introduces a breaking change (which will increment our major version). I'm not sure whether this is an issue.

borisrizov-zf commented 8 months ago

@DominikPinsel not an issue, semantic-release will take care of this. I've updated the node version in release.yaml so please rebase this branch. Otherwise you'll get an error when semantic-release tries to create the version. Keep an eye on this https://github.com/eclipse-tractusx/managed-identity-wallet/actions/runs/7538530957 and rebase when it's done.

sonarcloud[bot] commented 8 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

borisrizov-zf commented 8 months ago

@DominikPinsel any ideas why this is still failing?

borisrizov-zf commented 8 months ago

@DominikPinsel new PR was merged, you'll have to rebase and please check the pipeline issue. Thanks.

DominikPinsel commented 8 months ago

@DominikPinsel any ideas why this is still failing?

I think so. As it is now it fails in the helm upgrade step. I assume this is because it also tries to upgrade the PostgreSQL version, which does not work as we have increases the postgresql major version.

borisrizov-zf commented 8 months ago

Does it succeed in your fork or locally?