eclipse-tractusx / managed-identity-wallet

Apache License 2.0
9 stars 22 forks source link

Feat: Create VC as JWT #260

Closed mustafasalfiti closed 4 months ago

mustafasalfiti commented 7 months ago

Description

In the Controllers, an option has been added to generate a VC as a JWT (JSON Web Token). By default, this option is set to false. When set to true, the response will be a JWT containing the VC.

Additionally, certain exception handling has been revised and corrected due to the integration of the new SSI-lib

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

mustafasalfiti commented 5 months ago

should be with the latest ssi agent lib current (main) in order for the tests to work @borisrizov-zf

borisrizov-zf commented 5 months ago

@mustafasalfiti I'll ping you when the new release of the ssi-lib is out, so you can update.

borisrizov-zf commented 4 months ago

IP check link: https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14592 IP check status: Approved

Ready to merge.

borisrizov-zf commented 4 months ago

@mustafasalfiti please rebase to the latest develop version (there was a minor update merged a week ago).

borisrizov-zf commented 4 months ago

@thackerronak Hi, it seems something went wrong with the rebase/merge since now we're getting unwanted changed in the CHANGELOG. Please review and push again.

nitin-vavdiya commented 4 months ago

@borisrizov-zf Rebase is done

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.6% Duplication on New Code

See analysis details on SonarCloud

borisrizov-zf commented 4 months ago

@nitin-vavdiya Hi, I'm doing manual tests. If all goes well, I'll merge and notify you.

borisrizov-zf commented 4 months ago

Dash review required https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14889

github-actions[bot] commented 4 months ago

:tada: This PR is included in version 0.5.0-develop.15 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

github-actions[bot] commented 3 months ago

:tada: This issue has been resolved in version 0.5.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: