eclipse-tractusx / managed-identity-wallet

Apache License 2.0
7 stars 20 forks source link

feat: intial revocation service added #317

Open nitin-vavdiya opened 3 weeks ago

nitin-vavdiya commented 3 weeks ago

Description

Work in progress

  1. DevOps things like helm charts
  2. Readmes

Creating draft PR so we can have early reviews regarding revocation service

Why

In the current application implementation, we cannot issue credentials that can be revoked.

What

Revocation service added to support revocable credential

This is ref. implementation of bitstring status list

This is originally developed at Cofinity-X

Thanks, @mustafasalfiti and @pmanaras for initial contribution.

Ref:

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

borisrizov-zf commented 3 weeks ago

Merged #318, you'll need to rebase at some point.

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
33 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.5% Duplication on New Code

See analysis details on SonarCloud

nitin-vavdiya commented 2 weeks ago

Hi @nitin-vavdiya did you notice that the contribution #317 is much to huge? (max. 1,000 lines of content (including documentation, code, configuration files, and other forms of source code, see https://www.eclipse.org/projects/handbook/#ip-project-content). I don't think it's reasonable that someone would be able to review such a huge PR.

Hi @nitin-vavdiya did you notice that the contribution #317 is much to huge? (max. 1,000 lines of content (including documentation, code, configuration files, and other forms of source code, see https://www.eclipse.org/projects/handbook/#ip-project-content). I don't think it's reasonable that someone would be able to review such a huge PR.

Yes, this is a huge PR as this contains the entire revocation application(APIs, test cases, docs etc) if we push partial changes then the test/checks will not pass or not meet the TRGs(specially document and chart related) We need an IP review/check for this PR.

evegufy commented 2 weeks ago

Hi @nitin-vavdiya did you notice that the contribution #317 is much to huge? (max. 1,000 lines of content (including documentation, code, configuration files, and other forms of source code, see https://www.eclipse.org/projects/handbook/#ip-project-content). I don't think it's reasonable that someone would be able to review such a huge PR.

Hi @nitin-vavdiya did you notice that the contribution #317 is much to huge? (max. 1,000 lines of content (including documentation, code, configuration files, and other forms of source code, see https://www.eclipse.org/projects/handbook/#ip-project-content). I don't think it's reasonable that someone would be able to review such a huge PR.

Yes, this is a huge PR as this contains the entire revocation application(APIs, test cases, docs etc) if we push partial changes then the test/checks will not pass or not meet the TRGs(specially document and chart related) We need an IP review/check for this PR.

Hi @nitin-vavdiya very good that you're aware that you need to request an ad hoc IP review in such a case. Still, please keep in mind the following in mind, especially for future contributions: the measure of an ad hoc IP review should be used in extraordinary cases when it it is really not possible to remain under 1000 lines. I'd argue that the api implementation and the according tests could have been tailored and therefore contributed in multiple contributions but especially no TRG promotes huge contributions, they actually promote the contrary, for instance the documentation and the helm chart can be contributed in different pull requests, no TRG requires you otherwise.

Hi @borisrizov-zf, as product expert and committer besides @nitin-vavdiya, are you confident in reviewing this PR?

borisrizov-zf commented 2 weeks ago

@evegufy Yes, I'm aware of the size, but since @nitin-vavdiya is a committer, the 1000 lines limit doesn't apply. The review is ongoing, I anticipate no issues to be honest since this code has been tested and used by Cofinity-X.