search

eclipse-tractusx / managed-service-orchestrator

Apache License 2.0
6 stars 9 forks source link

fix: _Quality gate checks_ #74

Closed adkumar1 closed 1 year ago

adkumar1 commented 1 year ago
SebastianBezold commented 1 year ago

HI @adkumar1,

thanks for the changes. One remark to PR title and commit messages. The "_" in the tile seems to not add value. There is no Markdown rendering in the PR. Commit message should be more descriptive. Instead of just mentioning the fiele you changed, or which issue you fixed, describe the actual change. i.e. "add legal info to distribution in build"

Also: linking issues of forks as part of the commit message does not add value, since this info will be lost, once the fork will be deleted

adkumar1 commented 1 year ago

Will take care in future