search

eclipse-tractusx / managed-service-orchestrator

Apache License 2.0
6 stars 9 forks source link

fix: Testing of charts #92

Closed adkumar1 closed 11 months ago

adkumar1 commented 11 months ago
adkumar1 commented 11 months ago

@adityagajbhiye : Please review

SebastianBezold commented 11 months ago

Hi @adkumar1,

can you please also provide some details on this PR about the linting issue? It's not really visible, which of the changes fixes the lint part. Also, the PR seems to include changes that are unrelated to Chart linting. Please remove them from the PR

adkumar1 commented 11 months ago

Hi, Actually workflow was failing in test connection. I think below file is not mandatorily required which is applicable for test-connection. So this has been removed. charts/orchestrator/templates/tests/test-connection.yaml

SebastianBezold commented 11 months ago

Hi, Actually workflow was failing in test connection. I think below file is not mandatorily required which is applicable for test-connection. So this has been removed. charts/orchestrator/templates/tests/test-connection.yaml

So this is not at all about linting, but testing. Could you please adjust this in your PR title?

adkumar1 commented 11 months ago

Hi, Actually workflow was failing in test connection. I think below file is not mandatorily required which is applicable for test-connection. So this has been removed. charts/orchestrator/templates/tests/test-connection.yaml

So this is not at all about linting, but testing. Could you please adjust this in your PR title?

Updated the title