eclipse-tractusx / policy-hub

Policy Hub
Apache License 2.0
3 stars 10 forks source link

chore: fix ingress, improve dependencies check and add file header #147

Closed evegufy closed 3 months ago

evegufy commented 3 months ago

Description

Why

Checklist

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

evegufy commented 3 months ago

Overall LGTM, please add prerequisites to your chart again.

For helm check I just templated the chart with ingress.enabled = true and no error occurs (beside that the helm test workflow gonna test it).

Sidenote I missed previously, which I would not request as a point, but recommend: The system team provides an action for the changed dependency. You can refer to our workflow and increase the version of the dash tool here.

Good hint with the action from the systems team, I wasn't aware about that action, for now I'll leave the workflow as is because I have it running successfully in this manner a couple of other repos and I don't have time to rework it too much and don't want to spare such features like uploading the file if changed.