eclipse-tractusx / policy-hub

Policy Hub
Apache License 2.0
4 stars 12 forks source link

[E2E]: Policy Hub Contract Reference dropdown field #186

Closed ciprianherciu closed 2 months ago

ciprianherciu commented 2 months ago

Current Behavior

Contract Reference Option does appear in Policy Hub, but the field type is a dropdown one. Although there is a note that the bilateral contract name should be added in the right operand there is no field to do it in. Issue now it is not possible to add the Bilateral contract name. Contract Reference is a dropdown field. Only Option is {bilateralContractName} image

Expected Behavior

  1. The ContractReffrence dropdown should contain possible Contract Reference names (as it is for UsagePupose or FrameworkAgreement)
  2. ContractReffrence should be a text field where the bilateral contract name is writeable

Steps To Reproduce

Create a policy using Policy Hub

jjeroch commented 2 months ago

@ciprianherciu can you please add a better description. It is not possible to understand what you want. We can not support such tickets.

On top of that, please use screenshots where possible.

Bug declined. The policy hub was tested and works as planned. No issue

ciprianherciu commented 2 months ago

@jjeroch The Contract Reference field is present. Type of the field is a Dropdown. Only Dropdown option is {bilateralContractName}. Is this is how it supposed to work? Other Dropdown fields from Policy Hub have options

jjeroch commented 2 months ago

@ciprianherciu the contract reference is not a dropdown field. The contractReference is a bilateral contract name which is created on paper between two parties. We can off course not know the contract name; the right operand is a free-text-field

ciprianherciu commented 2 months ago

@jjeroch To use the Policy Hub, we have categorized the fields based on the attributes: • If the attribute is static than the field will be a dropdown field • If the attribute is Regex than it will be an input field f.e.: image

Since ContractReffrence has the attribute Static which will be represented in SDE as a dropdown field. If it is expected that the bilateral contract name should be written in a text field, could we adjust the attribute to Regex, as it is for the BPNL?

jjeroch commented 2 months ago

@ciprianherciu it is always a huge risk which you take if you implement an logic which is not supported/not shared/proposed by the actual data provider. You implemented based on own assumptions of type meanings. Thats not recommended. For me the regex is not making sense since there are no limitations; regexes are important if you have a fix given set of characters. However leaving the decision for @MaximilianHauer

evegufy commented 2 months ago

relates to https://github.com/eclipse-tractusx/policy-hub/issues/176

MaximilianHauer commented 2 months ago

@ciprianherciu we should not adjust the policy configuration only that it fits your needs. if you notice that the implementation of yours is not fitting then this is the place to improve on and not the setup of the policy. As @jjeroch mentioned the idea of a regex is to ensure data quality as there is no specified data quality check for a bilateralContactName we wont implement it like this.