eclipse-tractusx / portal-backend

Portal Backend
Apache License 2.0
7 stars 20 forks source link

Cleanup - Notification Endpoints #812

Closed jjeroch closed 1 month ago

jjeroch commented 3 months ago

Validation and explanation needed why we have 2 different "Create" notification endpoints:

image
Phil91 commented 3 months ago

@jjeroch there should only be one endpoint to create credentials (for the ssi decline, approve and expiry use cases), the other one is to just update the read status of a notification

jjeroch commented 3 months ago

@Phil91 thanks. I like to do an adjustment here - the endpoint is super specific for SSI Credentials. I don't see a reason why we make it so specific. We should apply an update to change the endpoint name

Additional needed change: adjust the attribute requester to receiver Please recheck the logic to set the creator user ID - it must be assured that the creator is always correctly set based on the technical user or company user which runs the endpoint.

breakingChange #internalBreaking

Phil91 commented 1 month ago

@MaximilianHauer @ntruchsess as discussed the create endpoint will stay as it is for the specific useCase of creating a notification for the credentials. We will adjust the role to be more specific from create_notifications to create_ssi_notifications