Introduce feature toggle for bpdm sharing state - Githubissues

eclipse-tractusx / portal-backend

Portal Backend

Apache License 2.0

8 stars 20 forks source link

Introduce feature toggle for bpdm sharing state #845

Closed Phil91 closed 3 weeks ago

Phil91 commented 3 months ago

Description

Since the bpdm has the option to automatically set the sharing state to ready, see: https://github.com/eclipse-tractusx/bpdm/blob/release/6.0.x/bpdm-gate/src/main/resources/application.yml

tasks:
    creation:
      fromSharingMember:
        # If true, new business partner input data will be directly ready to be shared
        # If false, new business partner input data need to be manually set to ready
        starts-as-ready: true

it would make sense to add a feature toggle in the backend to skip the /v6/sharing-state/ready call in the CREATE_BUSINESS_PARTNER_NUMBER_PUSH application checklist step - see https://github.com/eclipse-tractusx/portal-backend/blob/e20a452aa7aa51b7ed43175debbebb4f9808219c/src/externalsystems/Bpdm.Library/BusinessLogic/BpdmBusinessLogic.cs#L92

Acceptance Criteria

[x] Feature toggle is added to disable the call to set the sharing state
[x] If the call is disabled the call will not be executed
[x] Unit Tests are added
[x] Documentation for feature toggle added

Phil91 commented 3 months ago

@jjeroch @MaximilianHauer fyi - in results of the discussion in issue https://github.com/eclipse-tractusx/portal-backend/issues/830 I've added this issue.