search

eclipse-tractusx / portal-backend

Portal Backend
Apache License 2.0
9 stars 21 forks source link

Analysis: Registration Retrigger endpoints for credentials #849

Closed jjeroch closed 1 month ago

jjeroch commented 4 months ago

Summary:

Endpoints POST /api/administration/registration/issuer/bpncredential and POST /api/administration/registration/issuer/membershipcredential need review and potential restructuring to improve clarity and maintainability.

Description:

Upon recent review, it has been identified that the endpoints POST /api/administration/registration/issuer/bpncredential and POST /api/administration/registration/issuer/membershipcredential may be superfluous, as the steps they cover are supposed to execute automatically as part of the registration process. These endpoints appear to serve as manual retrigger points for the process worker automatic steps, leading to potential confusion regarding their purpose.

The primary objectives for this ticket are:

  1. Endpoint Analysis: Collaborate with the Product Owner to analyze the necessity of these endpoints.
  2. Clarification of Purpose: If these endpoints are indeed for retrigger purposes, clarify their roles within the system.
  3. Restructuring Proposal: Suggest moving these endpoints to a separate controller named "Registration Error Management" to segregate manual retrigger actions from the main flow.

Acceptance Criteria:

  1. Stakeholder Meeting: Arrange a meeting with the Product Owner to discuss the current implementation and use cases of the aforementioned endpoints.
  2. Document Findings: Record the outcome of the discussions, including any justification for the endpoints' existence provided by the PO.
  3. Technical Assessment: Provide a technical assessment of the impact and risks associated with removing or restructuring these endpoints.
  4. Proposal Documentation: If restructuring is advised, draft a detailed proposal outlining the new controller structure, including endpoint mappings and any necessary refactoring.
  5. Approval Process: Submit the proposal for review by the development team and the Product Owner for approval.
jjeroch commented 4 months ago

Created the issue in the wrong repo. @Phil91 can you please move the ticket to the backend repo?

Phil91 commented 3 months ago

@jjeroch done :)

Phil91 commented 3 months ago

@MaximilianHauer we should discuss this, could you maybe set up a meeting?

MaximilianHauer commented 1 month ago

not needed