eclipse-tractusx / portal-frontend

Portal Frontend
Apache License 2.0
5 stars 32 forks source link

Service overview shows only greyed out status labels #1231

Open MaximilianHauer opened 1 day ago

MaximilianHauer commented 1 day ago

Current Behavior

image

Expected Behavior

Steps To Reproduce

  1. go to https://portal.int.catena-x.net/serviceOverview
  2. check the status label of the services
manojava-gk commented 1 day ago

@MaximilianHauer recent update(@shahmargi12) in the shared-component's CardChip component expecting smallcase status text. Current behaviour is not changing the server value which is in UPPERCASE to the lowerCase. Similar behaviour is handled in the AppOverview section where the status is explicitly changed to lowerCase. Considering that case, I will update the status in the service card to the lowerCase.

CC - @oyo

shahmargi12 commented 1 day ago

@MaximilianHauer recent update(@shahmargi12) in the shared-component's CardChip component expecting smallcase status text. Current behaviour is not changing the server value which is in UPPERCASE to the lowerCase. Similar behaviour is handled in the AppOverview section where the status is explicitly changed to lowerCase. Considering that case, I will update the status in the service card to the lowerCase.

CC - @oyo

@manojava-gk I have removed conversion of status to toLowerCase because the type of status prop defined previously is already in lowerlCase so if any one pass UPPERCASE value in status prop, then it will show type error where it is used. So it is better if status is passed as lowerCase. If you want then we can also manage it in cardChip component by converting status to lowerCase.

export enum StatusVariants { release = 'release', active = 'active', inactive = 'inactive', created = 'created', inReview = 'in_review', enabled = 'enabled', }

export type Variants = | StatusVariants.release | StatusVariants.active | StatusVariants.inactive | StatusVariants.created | StatusVariants.inReview | StatusVariants.enabled`

shahmargi12 commented 23 hours ago

@MaximilianHauer @manojava-gk @oyo Updated the code in cardChip component. PR Link - https://github.com/eclipse-tractusx/portal-shared-components/pull/351

manojava-gk commented 18 hours ago

@shahmargi12 thanks for the PR but lets wait for @oyo's input.