eclipse-tractusx / portal-frontend

Portal Frontend

Apache License 2.0

5 stars 35 forks source link

ci: modify dependencies check to run only on yarn.lock updates #1310

Closed shahmargi12 closed 2 weeks ago

shahmargi12 commented 2 weeks ago

Description

Modify dependencies check to run only on yarn.lock updates

Why

Optimize CI by running dependency checks only when yarn.lock changes.
https://github.com/orgs/eclipse-tractusx/projects/61/views/1?pane=issue&itemId=86504502

Issue

1306

Checklist

Please delete options that are not relevant.

[X] I have followed the contributing guidelines
[X] I have performed a self-review of my own code
[X] I have successfully tested my changes locally

sonarcloud[bot] commented 2 weeks ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

typecastcloud commented 2 weeks ago

I would guess that the title should be ci: modify dependencies check to run only on yarn.lock updates.

Hi @evegufy, should the workflow not also run if someone made adjustments to the DEPENDENCIES file? To prevents invalid changes.

evegufy commented 2 weeks ago

I would guess that the title should be ci: modify dependencies check to run only on yarn.lock updates.

Hi @evegufy, should the workflow not also run if someone made adjustments to the DEPENDENCIES file? To prevents invalid changes.

@typecastcloud good suggestion, yes, agree, would make sense to add the DEPENDENCIES file as well. PR(s) already got merged. Would it be ok for you to take this up when you come around to it?