search

eclipse-tractusx / portal-frontend

Portal Frontend
Apache License 2.0
5 stars 32 forks source link

Semantic Model Page - responding with errors #446

Closed jjeroch closed 7 months ago

jjeroch commented 9 months ago

Detected in version: 23.12. // v.1.7.0

Summary

Portal page "Semantic Models" running on errors connected to the Semantic Hub Backend application.

image

Expected Behavior: No error displayed, diagram endpoint response received and can get displayed inside the semantic model overlay

=> connection to semantic product https://github.com/eclipse-tractusx/sldt-semantic-hub/issues/157

jjeroch commented 9 months ago

Blocked! Waiting for semantic model team response

jjeroch commented 8 months ago

Hi Mano, can you please revisit the issue. Latest feedback from the backend side:

This issue in the Semantic Hub is specifically regarding image generation for models using the SDK. Which is already fixed in the Semantic Hub 0.2.15 version.

The error occurred during the generation of SVG or PNG images for models, as the SDK was creating new temporary files for each "get diagram" request. This process would eventually lead to memory saturation and subsequently, the pod will go down.

For the older version of the BAMM model, we were utilizing the Open Manufacturing SDK, while the BAMM 2.1 and SAMM models relied on the ESMF SDK for diagram generation.

I am pleased to inform you that I have successfully addressed and resolved this issue for the ESMF SDK. The corresponding pull request has already been merged in SDK version 2.2.3.

In our discussions with Roman and Matthias, we determined that we had not pursued a fix for the Open Manufacturing SDK, as we were aware of its impending removal from the Semantic Hub. Consequently, in the latest Semantic Hub version, the usage of Open Manufacturing SDK has been eliminated.

Please be advised that this image generation issue will persist only for older BAMM models, as the Open Manufacturing SDK is used. if we use SH version 0.2.14 or lower. We anticipated that this problem would persist until the older SDK is removed from the codebase.

If you have any further questions or concerns, please don't hesitate to reach out if not then I request to close this issue.

Latest Update: The backend is updated to the newest sdk (2.4.2). Is the UI Part done?

jjeroch commented 8 months ago

@manojava-gk please note - @mkanal will take over this ticket. I will assign the ticket to @mkanal . @mkanal please ensure to follow the contribution rules

ds-mmaul commented 8 months ago

As @ds-lcapellino already mentioned in issue https://github.com/eclipse-tractusx/sldt-semantic-hub/issues/157, we would need some more information and support to be able to have a running environment in which we can investigate the issue. @jjeroch @manojava-gk : maybe someone of you know someone with whom we can get into contact or a call regarding this?

evegufy commented 8 months ago

As @ds-lcapellino already mentioned in issue eclipse-tractusx/sldt-semantic-hub#157, we would need some more information and support to be able to have a running environment in which we can investigate the issue. @jjeroch @manojava-gk : maybe someone of you know someone with whom we can get into contact or a call regarding this?

Hi @ds-mmaul is this question still open or was it addressed by the chat we had yesterday?

ds-mmaul commented 8 months ago

As @ds-lcapellino already mentioned in issue eclipse-tractusx/sldt-semantic-hub#157, we would need some more information and support to be able to have a running environment in which we can investigate the issue. @jjeroch @manojava-gk : maybe someone of you know someone with whom we can get into contact or a call regarding this?

Hi @ds-mmaul is this question still open or was it addressed by the chat we had yesterday?

Hi @evegufy we are now in a state where we are able to provide a fix via pull request next week. @ds-lcapellino will keep you updated here when its ready. Thank you!

ds-lcapellino commented 8 months ago

Hello @evegufy and @jjeroch, please see my PR https://github.com/catenax-ng/tx-portal-frontend/pull/426 for a potential fix. If you have any questions please reach out to me. Best regards.

evegufy commented 8 months ago

Hello @evegufy and @jjeroch, please see my PR catenax-ng#426 for a potential fix. If you have any questions please reach out to me. Best regards.

Hi @ds-lcapellino thank you! could you please raise the PR from the fork in catenax-ng to the dev branch in eclipse-tractusx https://github.com/eclipse-tractusx/portal-frontend/pulls?

evegufy commented 8 months ago

@ds-lcapellino thanks you for the contribution, it was reviewed and merged by our frontend lead. If you plan further contributions (which we very much welcome 👍 ), please create a fork from origin https://github.com/eclipse-tractusx/portal-frontend and not from a fork, please ignore the fork in the catenax-ng GH org.

cc: @jjeroch

jjeroch commented 8 months ago

Next step: test data load needed to test the defect fix - if the data load shouldn't be possible; we will wait for retest on INT. Ticket status updated to "In Review"

jjeroch commented 7 months ago

Test @ds-mmaul test data have been loaded into dev. Tests are executed and result is as expected - thanks for the fix