chore: improve pre commit hook and prettier checks

oyo commented 2 weeks ago

Description

Implement pre-commit hook the intended way

Why

The current pre-commit hook is poorly implemented because

prettier and linter are always running on all files not only staged ones
files modified by prettier are not added to the initial commit thus requiring an additional commit
unit tests are not executed on staged files

this commit solves all the issues implementing the pre-commit hook the intended way nevertheless we also added pretty checks to the PR check pipeline breaking it in case of unformatted files.

Issue

n/a

Checklist

Please delete options that are not relevant.

[x] I have followed the contributing guidelines
[x] I have performed a self-review of my own code
[x] I have successfully tested my changes locally
[x] I have added tests that prove my changes work
[x] I have checked that new and existing tests pass locally with my changes

evegufy commented 2 weeks ago

why are there so many new packages/dependencies added?

transitive from lint-staged package

oyo commented 2 weeks ago

why are there so many new packages/dependencies added?

@evegufy Only one dev dependency has been added - lint-staged. But it comes with many direct and indirect dependencies. This is a package that is only needed on the developer machine because it is executed before the commit. Maybe it's better to install this globally on the local machine because we don't need to download all those packages in the build pipelines. But then new developers might run into issues on their first commits.