eclipse-tractusx / portal-shared-components

Portal Shared UI Components
https://eclipse-tractusx.github.io/portal-shared-components
Apache License 2.0
1 stars 11 forks source link

feat: New Icon component #268

Closed charmi-v closed 1 month ago

charmi-v commented 1 month ago

Description

Component: Icon

Icon-Docs

Why

Introduced the new "Icon" component to enhance the shared-component library.

Issue

235

Checklist

Please delete options that are not relevant.

charmi-v commented 1 month ago

@jjeroch @oyo In package.json under devDependencies, we have "@storybook/test": "^8.1.6". The yarn.lock file lists @testing-library/jest-dom: 6.4.5 as a dependency, allowing us to use the library without explicitly listing it in package.json.

I included @testing-library/jest-dom@6.4.5 in devDependencies to:

The GitHub Workflow Actions (Check Dependencies / check-dependencies) failed with the latest version of @testing-library/jest-dom. I used the exact version 6.4.5 without the caret (^), which successfully passed the GitHub Action.

However, this prevents receiving bug fixes and new features, which may be a future blocker if updates are needed for @testing-library/jest-dom package.

Cofinity-UX commented 1 month ago

@charmi-v in your given screenshots all icons have the same size container. if a 8px icon is placed, would it still be possible to adjust the size of the container? Imagine there is a small 14px height button which requires a small icon – would the (assuming) 40px container of the icon create an issue?

charmi-v commented 1 month ago

@charmi-v in your given screenshots all icons have the same size container. if a 8px icon is placed, would it still be possible to adjust the size of the container? Imagine there is a small 14px height button which requires a small icon – would the (assuming) 40px container of the icon create an issue?

The container in the screenshots is for illustration only and will not be rendered with the Icon component. Only the icon itself will be rendered, and as you can see, the inherit version of the icon is used within a button component itself, so one can adjust the icon size without any issues related to the container.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ybidois commented 3 weeks ago

Great work @charmi-v! 👏

MaximilianHauer commented 3 weeks ago

woah ! thank you for your support 👍