charmi-v commented 3 weeks ago

Description

Shared component containing error handlers with console.log

Icon
Image

Why

Added an onError prop to the shared component to handle errors from the parent component when the issue originates within the component.
This ensures that errors are communicated effectively to the user, rather than being overlooked, as might happen with a console log.

Issue

148

Checklist

Please delete options that are not relevant.

[x] I have followed the contributing guidelines
[x] I have performed a self-review of my own code
[x] I have successfully tested my changes locally
[x] I have commented my code, particularly in hard-to-understand areas

charmi-v commented 3 weeks ago

@charmi-v we already have a snackbar management logic in the portal-frontend where the snackbars are managed in Redux:

https://github.com/eclipse-tractusx/portal-frontend/blob/main/src/features/control/notify.ts https://github.com/eclipse-tractusx/portal-frontend/blob/main/src/services/NotifyService.ts https://github.com/eclipse-tractusx/portal-frontend/blob/main/src/components/pages/Test/index.notify.tsx

I think a better solution is to pass a error or success handler function to the according shared components as props - this could be NotifyService.(error|success)

@oyo Thank you for highlighting that! I appreciate the context regarding the existing snackbar management in the portal-frontend.