fix: update useEffect dependency, handleChange

shubhamv-ss commented 3 weeks ago

Description

With ref to this PR https://github.com/eclipse-tractusx/portal-shared-components/pull/257, I found an issue for the <SelectList/> component caused by my previous changes on the Connector Registration screen.

By using JSON.stringify(defaultValue), we create a new string representation of the object on every render. When the properties of the object change, the string representation also changes, which triggers the effect to be re-run.
The value should clear when clicking on the X button in the <SelectList /> component.
I tested this component by copying all the files related to <SelectList /> in the local for the Connector Registration and theApp Realease Process step 1.

Please delete options that are not relevant.

shubhamv-ss commented 2 weeks ago

Hi @evegufy , Could you check this PR?

typecastcloud commented 1 week ago

Hi @MaximilianHauer, can you please check the second video here. This might be an issue that you notice when running tests on connector registration.

Shubham is on a break right now but I have access to his fork.

CC: @saadanzari

MaximilianHauer commented 1 week ago

@typecastcloud thx that's exactly what i experienced :)

topic i raised

related PR

https://github.com/eclipse-tractusx/portal-frontend/pull/1085
@oyo / @lavanya-bmw can you please align how to continue on this topic as we have now two drifferent PR

sonarcloud[bot] commented 4 days ago