eclipse-tractusx / portal-shared-components

Portal Shared UI Components
https://eclipse-tractusx.github.io/portal-shared-components
Apache License 2.0
2 stars 14 forks source link

fix(new toggle switch): remove the on off text #330

Closed kunalgaurav-bmw closed 1 month ago

kunalgaurav-bmw commented 2 months ago

Description

Removed the on off text from toggle switch

Why

On and Off text not required any more from demo feedback

Issue

https://github.com/eclipse-tractusx/portal-shared-components/issues/254

Checklist

Please delete options that are not relevant.

evegufy commented 2 months ago

Hi @kunalgaurav-bmw @oyo I looked into the failing dependencies check and it can be ignored in case of electron-to-chromium for now. This IP Issue https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/16197 was opened by another Eclipse Project, for the dependency which was previously already considered approved by the Dash Tool and therefore is already integrated into our repo. What's strange is that the IP issue ran nonetheless into a manual review: I assume it's a false positive and will be approved in the next couple of days once somebody checks it out. So, let's monitor IP issue and see if we can update the DEPENDENCIES file in a couple of days.

evegufy commented 1 month ago

@kunalgaurav-bmw https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/16197 is approved, please update dependencies file

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud