feat(dim): wallet creation config #453 - Githubissues

eclipse-tractusx / portal

Portal - Helm charts

Apache License 2.0

7 stars 7 forks source link

feat(dim): wallet creation config #453 #214

Closed ntruchsess closed 4 months ago

ntruchsess commented 4 months ago

Description

configuration for dim wallet creation has been added redundant configuration for onboardingserviceprovider has been removed.

Why

dim configuration is required for merge of https://github.com/eclipse-tractusx/portal-backend/pull/523 removal of redundant onboardingserviceprovider configuration enhances maintainability

Issue

https://github.com/eclipse-tractusx/portal-backend/issues/453

Link to pull request from other repository.

https://github.com/eclipse-tractusx/portal-backend/pull/523

Checklist

Please delete options that are not relevant.

[X] I have performed a self-review of my changes
[ ] I have successfully tested my changes
[X] I have added comments in the default values.yaml file with helm-docs syntax ('# -- ') if relevant for installation
[ ] I have commented my changes, particularly in hard-to-understand areas

ntruchsess commented 4 months ago

LGTM regarding DIM config but I don't get the change for the onboardingserviceprovider in this PR. IMO this should be a separate change or at least mentioned in the PR description.

description of onboardingServiceProvider has been added to the PR description