Closed typecastcloud closed 1 month ago
BPDM Compatibility:
BPDM allows up to 250 characters for company names and is unicode compatible. Characters for Polish or Chinese for example are therefore also allowed.
I don't see any issue with this change regarding BPDM compatibility.
@MaximilianHauer Hi Max, we still have chinese/thai/polish characters open as a topic.
There is a way to simplify REGEX via unicode scripts. \p{Letter} covers all letters in any language for example. See unicode scripts.
This would require our frontends to compile at least ES6 since support from then on. (compilerOptions still targets es5)
CC: @ybidois
From my pov okay. Support of ES6 is quite good globally (roughly 1 percent less than ES5) and enterprise users are more likely to run an up-to-date browser: https://caniuse.com/?search=es6 vs. https://caniuse.com/?search=es5
Description
We have some limitations to company REGEX that prevents onboarding of some customers.
1. Special Language Characters (Pending decision)
Currently the REGEX for legal company names is very restrictive. Special characters for some languages like German or French is allowed (e.g. üäöáè). Other languages are not considered:
Options:
Additional Information
For 1. companies need translated legal name to onboard their company. Options 2. & 3. have some additional technical risks since some components (bpdm/clearing house) might not support special characters of this type.
2. Company Name Length (Required change for us)
There are companies with very long company names. We could find suppliers/partners in BPDM pool with up to 160 characters (more can happen but is unrealistic). Now: 2-50 characters (currently counting white spaces) Expected: 1-160
Additional Information
UI risk:
Compatibility risk ???
Acceptance Criteria
Additional Information
I have code ready for both changes with test cases. Waiting for decision on special character topic before creating PRs.
@jjeroch @evegufy
Usage of UNICODE scripts for extended REGEX like /p{L} requires minimum compile target of EC6 cc: @oyo