Refactor ErpAdapterService - Githubissues

eclipse-tractusx / puris

Predictive Unit Real-Time Information Service (PURIS) for Short Term Demand and Capacity Management

Apache License 2.0

9 stars 9 forks source link

Refactor ErpAdapterService #419

Open tom-rm-meyer-ISST opened 5 months ago

tom-rm-meyer-ISST commented 5 months ago

As Developer, I want to clean up the ErpAdapterService, so that we don't have technical debts.

Hints / Details

See findings in acceptance criteria

Outcome / Acceptance Criteria

Outcome

...
Acceptance Criteria
DataInjectionCommandLineRunner: remove mock request
ErpAdapterController: add status codes 500 for any server side issue, 400 for bad request
Add tests for mapper
Double check that there is a test for the existing mapper if materialGlobalAssetId is empty
Align content of ErpAdapterRequest.requestType and add it as enumeration (with one entry), also check for version

Out of Scope

...

Decomposed into

[x] #584
[ ] #583

eschrewe commented 5 months ago

Additional TODOS:

ItemStockErpAdapterService -> uncomment check for existing response
ErpAdapterContoller -> edit swagger descritption
ErpAdapterRequestService -> remove mock code from get method