Closed ds-jhartmann closed 11 months ago
hi @ds-jhartmann, secrets added, pls check on your side:
Unfortunately the secret names indicate a org wide secret, but it was configured as repo secret. Are these secrets hard coded into your code?
I'd prefer to rename the secrets to IRS_OAUTH2_CLIENT_ID_DIL
and IRS_OAUTH2_CLIENT_SECRET_DIL
to match the naming schema, @ds-jhartmann
@carslen Oh, I was not aware of this implication. I used the naming convention for quite a while now, since sometime in the past it was communicated to do it like this. The secrets are already part of a workflow, but if you prefer to rename them, it is not a big effort to change the names
It would be great if we could align the secret names.
, but if you prefer to rename them, it is not a big effort to change the names
... i would prefer a rename to @carslen's proposal to IRS_OAUTH2_CLIENT_ID_DIL
and IRS_OAUTH2_CLIENT_SECRET_DIL
Is this possible for you @ds-jhartmann to change your workflow files?
@FaGru3n yes, I will update our workflows accordingly. Thank you!
new repository secrets were created:
@ds-jhartmann please give us a little feedback if your workflows are running with new secrets, then we will remove the former ones
ORG_IRS_OAUTH2_CLIENT_ID_DIL
and ORG_IRS_OAUTH2_CLIENT_SECRET_DIL
Hi @ds-jhartmann any updates and could we delete the "other" repo secrets? 😉
Hi @FaGru3n, sorry about the silence, I completely forgot to update you. We adjusted our workflow and everything is working with the updated names. The old entries can be deleted. Thank you very much!
Secrets were deleted issue can be closed
Could you please add two new GitHub secrets for the project https://github.com/catenax-ng/tx-item-relationship-service
secret name: ORG_IRS_OAUTH2_CLIENT_ID_DIL secret value: please take the value from https://vault.demo.catena-x.net/ui/vault/secrets/traceability-irs/show/dil/keycloak/oauth2#clientId
secret name: ORG_IRS_OAUTH2_CLIENT_SECRET_DIL secret value: please take the value from https://vault.demo.catena-x.net/ui/vault/secrets/traceability-irs/show/dil/keycloak/oauth2#clientSecret
Kind regards