search

eclipse-tractusx / sig-infra

Apache License 2.0
2 stars 2 forks source link

Support for puml workflow #329

Closed tom-rm-meyer-ISST closed 8 months ago

tom-rm-meyer-ISST commented 8 months ago

Is your support request related to a problem? Please describe.
We introduced the new puml to svg workflow but we are not sure how to correctly unzip and commit the files to the respective directory.

We got this workflow run creating the artifacts correctly.

Describe the solution you'd like
I would like to add the following steps to the workflow:

potential problem: the commit MUST be signed by someone who signed the ECA (commonly the person triggering the run or the merge). Else the Eclipse Contributor Agreements will fail.

Additional context
It makes sense to update the examples referenced in the TRG Draft then accordingly :)

tom-rm-meyer-ISST commented 8 months ago

@FaGru3n, I would be grateful, if you could support! :)

FaGru3n commented 8 months ago

Hi @tom-rm-meyer-ISST,

great to hear that this workflow is needed and my work is appreciated. 😉

potential problem: the commit MUST be signed by someone who signed the ECA (commonly the person triggering the run or the merge). Else the Eclipse Contributor Agreements will fail.

Jep as you already get aware of upcomming problems i leave this part open to everyone to use it, because this depends on the team or strategies our teams are working. (I am thinking of approvals, committing rules, pull-requests, preview, forking, etc.)

If you want to change the behaviour you could also add more step´s / jobs to your workflow here

That´s why i add the comment, that you can now decide how you want to interact with the files like storing it into a separate branch or open a PR and commit it there. There are some cool ways on the GitHub Marketplace available and someone need a specific GitHub Token. (Please be patient with licences etc.)

Also a great help for me using the default permissions for a generated GitHub Token on the workflow run you can find here: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/3705

You could just use the standard {{ secrets.GITHUB_TOKEN }} that is setup for your workflow automatically to avoid running into rate limits. If you need additional permissions, request them as explained here: https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs

But as you said it, needs some fine set-up how you want to handle the storing part.

FaGru3n commented 8 months ago

FYI closed this one 😉