search

eclipse-tractusx / sig-release

https://eclipse-tractusx.github.io/sig-release
Apache License 2.0
6 stars 6 forks source link

[Product] PURIS FOSS Release Checks #589

Open tom-rm-meyer-ISST opened 2 months ago

tom-rm-meyer-ISST commented 2 months ago

[!IMPORTANT]
Follow the guidance on how to use the templates.

Release Info

Please provide information on what you want to be included in the Eclipse Tractus-X release. If you are not owner of this issue, please provide the information as comment to the issue. Make sure to assign this issue to expert(s) for their approval, as soon as you have finished preparation. Multiple assignees allowed; they will un-assign themselves once review completed.

Version to be included in Eclipse Tractus-X release: 2.0.0

Leading product repository: repository link

Compliance Verifications

This issue tracks all checks, that need to be performed for a product release in Eclipse Tractus-X.

General Checks

[!NOTE] Note: most criteria for documentation and security are now covered in TRGs

Security Checks

Test Results

Helpful Links

cc: @PhillipNalesny @Ute-Burkhardt-Volkswagen

tom-rm-meyer-ISST commented 1 month ago

Reviewing committer is @evegufy , thanks for taking that over! I'll inform you in a couple of weeks once you can start with the review

szymonkowalczykzf commented 1 month ago

Threat Modeling Approved. Changes reviewed, recommendations addressed & implemented.

rauschg commented 1 month ago

User journey is confirmed by the BO role

ThomasObermeyer commented 1 month ago

Reviewed interoperability requirements based on provided documentation. Most changes in this release were due to Industry Core and EDC IATP changes, which are in full alignment with our interoperability architecture.

@kelaja Approved!

RolaH1t commented 1 month ago

QG review 2024-05-14: data sov in process, no blockers, but expect known known. TRG ongoing in tandem with @evegufy; expect major version update to 2.0/3.0 Thread modelling completed; checkmark will be set once final PR merged (https://github.com/eclipse-tractusx/puris/pull/361) Successful completion of tests expected in cw21 QG not approved / no further meeting scheduled.

jjeroch commented 3 weeks ago

UI/UX Feedback: Tested with “Fraunhofer Gesellschaft”

Overall

Brief description at the top of each page describing content would be nice for better user experience.

 

Left Navigation Bar

Please use different icon for Catalog, Negotiations, Transfers - currently all with

image

Logout

 

Dashboard Customer

image

 

 

  

 

image

=> blocking design not ok!!

Stocks

Switch between Material Stocks and Product Stocks

--> suggest same layout adaption as for Dashboard Customer / Supplier View (see above)

image

 

--> however, user needs better guidance to do this (else error prone to enter one slightly different attribute and Add instead of update)

 

Proposal: Also would be good to have an update button right in the table to perform update.

 

image

Catalog

http://www.w3.org/ns/odrl/2/use (Aus https://puris-customer.int.demo.catena-x.net/catalog )) à is there a reason to call this “Asset condition(s)” rather than usage Policies?

 

--> maybe consider using a table view instead to show more items in overview

Similar for Negotiations View

 

 

Negotiations

 

OTHER

 

Responsiveness

Get Catalog with delay in loading results

Upon clicking get Catalog, screen initially changes to “No Catalog available…” and then takes a couple of seconds to load the catalog items.

image

 

 

ReneSchroederLJ commented 3 weeks ago

@jjeroch Thank you for your valuable feedback.

I have a question regarding one of your points. You mention that a footer component is missing. Can you elaborate on that? I couldn't find a reference to requirements for a footer component.

evegufy commented 3 weeks ago

TRG review successfully completed

KMA-2019 commented 3 weeks ago

@vialkoje , @cbrugg , @tom-rm-meyer-ISST as aligned referencing here notes / feedback from E2E Tests for Data Sovereignty. No blocking issues for current Rel 24.05 but some items to be considered for next release(s). Some of the below have already been created as bugs, @tom-rm-meyer-ISST please map accordingly, thanks!

cbrugg commented 3 weeks ago

E2E Tests / Data Sov Tests performed successfully. Some Findings will be addressed in a Patch Version. No Release Blockers. TM Approval given. Thank You!

RolaH1t commented 3 weeks ago

Congrats for crossing the finish line: Quality Gate fully approved with all necessary pre-requisites fulfilled! Thanks for all your efforts, Roland

jjeroch commented 3 weeks ago

@jjeroch Thank you for your valuable feedback.

I have a question regarding one of your points. You mention that a footer component is missing. Can you elaborate on that? I couldn't find a reference to requirements for a footer component.

Hi @ReneSchroederLJ it is not a hard requirement but a "feature" which usually comes with an app to manage Terms, Privacy, Cookies etc.

KMA-2019 commented 2 weeks ago

Hi @tom-rm-meyer-ISST , @ReneSchroederLJ , cc: @jjeroch Regarding UUX findings please see the retest results:

Thanks!

@jjeroch can you please review and decide about granting final approval.

Overall

Brief description at the top of each page describing content would be nice for better user experience.

--> Changelog

Dashboard Customer

Create Demand - Upon entering data and closing, SOME (not all) entries are preserved (and so are warnings for mandatory fields) --> upon closing and re-opening information should be reset to default

--> Changelog

++ Also noticed that UOM Field has different opening behaviour, suggest to keep empty with "select unit" also for "Create Demand" :
Create Demand image Add Delivery image

Stocks

Switch between Material Stocks and Product Stocks --> suggest same layout adaption as for Dashboard Customer / Supplier View

Not changed but also not in ChangeLog -> OK from my side,

Like the functionality that by clicking on a stock, data gets entered for add/update --> however, user needs better guidance to do this (else error prone to enter one slightly different attribute and Add instead of update) Proposal: Also would be good to have an update button right in the table to perform update.

--> ChangeLog

Refresh -- update request has been sent successfully. Here, the process needs to be more transparent to the user. Not clear to which customer(s) what kind of data or request has been sent.

--> ChangeLog

Catalog

No Action possible from this list - > unclear to user when and how user will consume such an offer

--> ChangeLog

++ Also noticed that it is possible to select a row - and not able to deselect by clicking anywhere else.

image

Negotiations

To allow for better transparency suggest to include filter options, e.g. for State (Terminated, Finalized, ..), for Type, for BPN.

--> ChangeLog

Other

Help Feature missing

User Guide available not, not a general help section -> OK from my side

Footer Component missing

User Guide, About and Copyright Info are now available on each page -> OK from my side

tom-rm-meyer-ISST commented 2 weeks ago

Create Demand - Upon entering data and closing, SOME (not all) entries are preserved (and so are warnings for mandatory fields) --> upon closing and re-opening information should be reset to default

Thanks for your feedback. I updated the Release's Changelog accordingly.