search

eclipse-tractusx / sig-release

https://eclipse-tractusx.github.io/sig-release
Apache License 2.0
8 stars 8 forks source link

[Item Relationship] R24.5 Release Checks #670

Closed mkanal closed 4 months ago

mkanal commented 6 months ago

[!IMPORTANT]
Follow the guidance on how to use the templates.

RELEASE

Release Info

Please provide information on what you want to be included in the Eclipse Tractus-X release. If you are not owner of this issue, please provide the information as comment to the issue. Make sure to assign this issue to expert(s) for their approval, as soon as you have finished preparation. Multiple assignees allowed; they will un-assign themselves once review completed.

Version to be included in Eclipse Tractus-X release: 7.1.3

Leading product repository: https://github.com/eclipse-tractusx/item-relationship-service

Link

Compliance Verifications

This issue tracks all checks, that need to be performed for a product release in Eclipse Tractus-X.

General Checks

Security Checks

Test Results

Helpful Links

mkanal commented 5 months ago

@jjeroch could you please confirm, that no uux review is required for the IRS. Thank you very much.

jzbmw commented 5 months ago

User Journey is approved from BO Perspective.

mkanal commented 5 months ago

Good morning @guenterban, @bs-jokri, @pablosec,

in both products (Trace-X FOSS and IRS) there are no relevant system-related changes compared to R23.12 and R24.3. For this reason, we request the release of the QGC "Threat Modeling Analysis passed" based on version R23.12 & R24.3. If you come to a different conclusion, we will be happy to provide you with dates for the threat modeling analysis.

Sig-Release: Trace-X: https://github.com/eclipse-tractusx/sig-release/issues/611 IRS: https://github.com/eclipse-tractusx/sig-release/issues/670

Thank you very much IRS and Trace-X Team

mkanal commented 5 months ago

Good morning @almadigabor,

would you please again support the Team IRS regarding TRG checks for the upcoming release R24.5?

Thank you very much

Martin

guenterban commented 4 months ago

Threat Modeling Analysis approved

mkanal commented 4 months ago

Hi @almadigabor and @Siegfriedk

TRG Check for Release version

Support-Team for testing TRGs @ds-lcapellino and @ds-mwesener

QG Assessment is on 14.5.2024 11:00 Thank you very much Martin

vialkoje commented 4 months ago

is there a sovereignty check already conducted considering these criteria https://confluence.catena-x.net/x/NTeJBg ? I'd expect as you are using the edc - the only relevant part is the use of the correct BPN for accessing or providing data on the one side and the check for company-rules for accepting offers on the consumer side... I could nevertheless not validate that assumption

almadigabor commented 4 months ago

I've opened the TRG checks issue. https://github.com/eclipse-tractusx/item-relationship-service/issues/609

mkanal commented 4 months ago

is there a sovereignty check already conducted considering these criteria https://confluence.catena-x.net/x/NTeJBg ? I'd expect as you are using the edc - the only relevant part is the use of the correct BPN for accessing or providing data on the one side and the check for company-rules for accepting offers on the consumer side... I could nevertheless not validate that assumption.

@vialkoje irs is a data consumer. We consume complete data via the EDC which uses the SAP DIM to only consume data for BPNLs.

cbrugg commented 4 months ago

E2E Tests were successfully performed. INT Tests need to be documented/updated. Data Sov Tests outstanding. Thank You!

RolaH1t commented 4 months ago

QG review 14-May: data sov in progress; no blockers expected TRG completion soon expected; successful collaboration across products & with SystemTeam minor version expected for final release (5.1.3 & 7.1.3) no follow-up mtg required

ds-mwesener commented 4 months ago

Tractus-X Release Guidelines(TRGs) fulfilled https://github.com/eclipse-tractusx/item-relationship-service/issues/609

Release Checks approved ✅

RolaH1t commented 4 months ago

@vialkoje for IRS only data sov conclusion is outstanding. Are you fine with @mkanal `s comments and can you approve?

vialkoje commented 4 months ago

which uses the SAP DIM to only consu

@vialkoje irs is a data consumer. We consume complete data via the EDC which uses the SAP DIM to only consume data for BPNLs.

@mkanal : could you shortly explain on "how are the company rules put into the IRS by the user/admin of the IRS ? What happens if there are multiple acceptable policies ? -> what is the heuristic for selecting the right one and will the consuming party be aware about it ? thanks for clarifying !

cbrugg commented 4 months ago

As IRS is implicitly tested via Trace X App E2E tests passed successfully. INT Tests were performed "Best Effort" and documented. Due to Testdata Issues some tests were instable and focus was on Unit/Component and Moduletests. Testmanagement approval given.

KMA-2019 commented 4 months ago

@vialkoje , @cbrugg , @mkanal as aligned referencing here notes / feedback from E2E Tests for Data Sovereignty. No blocking issues for current Rel 24.05 but main items to be considered for next release(s):

vialkoje commented 4 months ago

@mkanal

  • current concept only handles one standard policy per DC BPN, not possible to configure separately for different partner BPNs (e.g. wrt "ContractReference" Constraint)

what happens if there are multiple acceptable offers ? can you shortly describe how the acceptability of an offer is configured by the consuming company ?

ds-jhartmann commented 4 months ago

@vialkoje

what happens if there are multiple acceptable offers ?

IRS first filters the EDC offers for the wanted asset (e.g. Digital Twin Registry or Submodel Data) if there are multiple offers for the search, IRS will start a negotiation with all of them. During the negotiation initiation, IRS then validates the policy of the offer with the policy configured for this BPN in IRS. If this policy matches, IRS starts the EDC negotiation, if not the negotiation will fail on IRS side. In case one of the offers has a matching policy, IRS will use this offer, if none of the offers have matching policies, IRS will abort the negotiation. If more than one offer has a matching policy, IRS will take the first successful response.

can you shortly describe how the acceptability of an offer is configured by the consuming company ?

We don't configure directly which policy to use. The accepted policy for a BPN is added to the IRS policy store (either by configuration or via IRS policy store API). The policies for the BPN of the provider are then validated with the policy of the offer. If the policy of the offer matches one of the policies configured for the BPN, IRS accepts the offer.

RolaH1t commented 4 months ago

ready to approve QG as soon as data sov is closed-out via @ds-jhartmann , @mkanal and @vialkoje

vialkoje commented 4 months ago

Configuration of acceptable policies in the IRS has to be communicated to the consuming entity - along with the fact to arbitrarily chose the first acceptable offer if multiple exist. Please point me to the documentation where this is described. Technically everything is implemented. Heuristic to select from multiple acceptable offers should be changed to be less arbitrary (choose first) and more user determined. Expert approval granted.

ds-jhartmann commented 4 months ago

Thank you @vialkoje, we will address this and make our documentation clearer on this matter.

@RolaH1t all QG checks are done and approved. I kindly ask for the final approval.

RolaH1t commented 4 months ago

Congrats: Quality Gate fully approved with all necessary pre-requisites fulfilled! Thanks for all your efforts, Roland

stephanbcbauer commented 4 months ago

Hello @mkanal

Since the feature is a 24.05 feature and the development phase for 24.08 is coming to an end, we need a status on the feature. Can you please update the status?

If you need any clarification, please get in touch, thank you very much.

Stephan

mkanal commented 4 months ago

Congrats: Quality Gate fully approved with all necessary pre-requisites fulfilled! Ticket will be closed.