eclipse-tractusx / sig-release

https://eclipse-tractusx.github.io/sig-release
Apache License 2.0
8 stars 10 forks source link

Managed Service Orchestrator Release 23.12 Documentation Acceptance Criteria #82

Closed kelaja closed 10 months ago

kelaja commented 1 year ago

Release Documentation 23.12

Source in Catena-X Confluence and Expert Contacts here (Source only accessible for Catena-X Consortia members in current transition phase).

MehranRoshandel commented 11 months ago

@dvasunin please add all documents regarding TX document and version here and add the latest version once is committed by @SebastianBezold

sharathshivprasad commented 11 months ago

source code: Latest release - https://github.com/eclipse-tractusx/managed-service-orchestrator/releases/tag/managed-service-orchestrator-1.5.1

Architecture Documents: ARC 42 link - https://github.com/eclipse-tractusx/managed-service-orchestrator/blob/managed-service-orchestrator-1.5.1/docs/ARC42.md

Administrator`s Guide (User assistance): Readme Link - https://github.com/eclipse-tractusx/managed-service-orchestrator/blob/managed-service-orchestrator-1.5.1/README.md install.md link - https://github.com/eclipse-tractusx/managed-service-orchestrator/blob/managed-service-orchestrator-1.5.1/INSTALL.md

End-User Manual: ARC 42 link - https://github.com/eclipse-tractusx/managed-service-orchestrator/blob/managed-service-orchestrator-1.5.1/docs/ARC42.md Readme link - https://github.com/eclipse-tractusx/managed-service-orchestrator/blob/managed-service-orchestrator-1.5.1/README.md

Interfaces Documentation: OpenAPI spec is available in the repository at - https://github.com/eclipse-tractusx/managed-service-orchestrator/blob/managed-service-orchestrator-1.5.1/docs/autosetup-api.yaml

UX consistency: Not Applicable

@SebastianBezold Please review and approve

SebastianBezold commented 11 months ago

source code: Latest release - https://github.com/eclipse-tractusx/managed-service-orchestrator/releases/tag/managed-service-orchestrator-1.5.1

Architecture Documents: ARC 42 link - https://github.com/eclipse-tractusx/managed-service-orchestrator/blob/managed-service-orchestrator-1.5.1/docs/ARC42.md

Administrator`s Guide (User assistance): Readme Link - https://github.com/eclipse-tractusx/managed-service-orchestrator/blob/managed-service-orchestrator-1.5.1/README.md install.md link - https://github.com/eclipse-tractusx/managed-service-orchestrator/blob/managed-service-orchestrator-1.5.1/INSTALL.md

End-User Manual: ARC 42 link - https://github.com/eclipse-tractusx/managed-service-orchestrator/blob/managed-service-orchestrator-1.5.1/docs/ARC42.md Readme link - https://github.com/eclipse-tractusx/managed-service-orchestrator/blob/managed-service-orchestrator-1.5.1/README.md

Interfaces Documentation: OpenAPI spec is available in the repository at - https://github.com/eclipse-tractusx/managed-service-orchestrator/blob/managed-service-orchestrator-1.5.1/docs/autosetup-api.yaml

UX consistency: Not Applicable

@SebastianBezold Please review and approve

Hi @sharathshivprasad,

I can only partly review things from this issue. One remark before I start. The tags you link are created by the Chart releaser. So there is no proper release tag yet. This also means, your Docker images with version 1.5.1 are missing. Could you please check if you actually did all the necessary steps for releasing?

adkumar1 commented 11 months ago

Hi @SebastianBezold I have raised a PR # https://github.com/eclipse-tractusx/managed-service-orchestrator/pull/83 It consist of trivy security fix. If all good you can release a new version 1.5.1

SebastianBezold commented 11 months ago

Hi @adkumar1, I merged the PR, created the Git tags and now the v1.5.1 Docker image tag is also available on DockerHub

There is also an open PR #81. Could you check the contents again. At least the helm upgrade part is needed to comply with the release guidelines. I'm just not sure about the huge k8s secret manifest

SebastianBezold commented 11 months ago

System Team Release Guideline checks tracked in eclipse-tractusx/managed-service-orchestrator#84

adkumar1 commented 11 months ago

Hi @SebastianBezold , helm upgrade part is added there in that PR. The secret part is included because earlier we were not able to deploy managed-service-orchestrator in other tools (like in argoCD). Hence we have included secret part with default values, so that we can deploy it anywhere. If someone want to change values then they can set in vault.

SebastianBezold commented 11 months ago

HI @adkumar1,

I merged the Helm Chart fix PR (eclipse-tractusx/managed-service-orchestrator#81) and created a fix release for the Chart. So the current Chart Version is 1.5.2, deploying AppVersion 1.5.1. I updated the README accordingly and also introduces a CHANGELOG.md for your Chart. See [8cdee67]{https://github.com/eclipse-tractusx/managed-service-orchestrator/commit/8cdee67b8008680cbca3a08024a0641815c94d67)

The changes done in the mentioned PR now at least enable the workflow to execute the Helm tests, but it is still failing. See workflow run logs

I created a new bug issue for that eclipse-tractusx/managed-service-orchestrator#87

Please fix the workflow run, so we can release a new patch version. You already had an exception for the last release. This time you need to get your test workflow to run successfully. This is a critical QA topic

vialkoje commented 11 months ago

managed service orchestrator == autosetup ??

MehranRoshandel commented 11 months ago

yes

SebastianBezold commented 11 months ago

managed service orchestrator == autosetup ??

I would really ask you to not use autosetup as name anymore. It has been renamed everywhere and only leads to confusion, if you still call it the old name. If the renaming was a mistake, then we should consistently undo it

SebastianBezold commented 11 months ago

managed service orchestrator == autosetup ??

I would really ask you to not use autosetup as name anymore. It has been renamed everywhere and only leads to confusion, if you still call it the old name. If the renaming was a mistake, then we should consistently undo it

Oh now that I also had a look at the docs, I can see the whole renaming is very inconsistent. There are multiple mentions of "autosetup". There is also an openAPI file named after autosetup.

@MehranRoshandel could you please ask the team to do the renaming consitently. @vialkoje what do you think about that. Are there other references, that still talk about "autosetup"? Maybe even in other places as the product repo itself?

MehranRoshandel commented 11 months ago

Yes, I did it already in the internal communication. But Again. Please mention the new Name Managed Service Orchestrator, everywhere.

SebastianBezold commented 11 months ago

Hi @MehranRoshandel,

could you please ask your team to actively check for quality gate findings and fix them? They are all described as issues on your product repos. This is actually relevant for all of your repositories. For managed-service-orchestrator there are three issues currently

MehranRoshandel commented 11 months ago

Actually, I do that the whole time. I am aware of the issues, and we are checking. But I have been back since yesterday. 😊

Dr. Ing. Mehran Roshandel

T-Systems International GmbH PU Digital Solutions | Data Intelligence Hub Senior Product Manager Holzhauser Str. 4-8 D-13509 Berlin Tel. +49 1718672876 Email @.**@.>

Letβ€˜s power higher performance [signature_791559559] https://dih.telekom.com/en/ You can find the obligatory information on: www.t-systems.com/compulsory-statementhttp://www.t-systems.com/compulsory-statement

Von: Sebastian Bezold @.> Gesendet: Dienstag, 21. November 2023 10:20 An: eclipse-tractusx/sig-release @.> Cc: Roshandel, Mehran @.>; Mention @.> Betreff: Re: [eclipse-tractusx/sig-release] Managed Service Orchestrator Release 23.12 Documentation Acceptance Criteria (Issue #82)

Hi @MehranRoshandelhttps://github.com/MehranRoshandel,

could you please ask your team to actively check for quality gate findings and fix them? They are all described as issues on your product repos. This is actually relevant for all of your repositories. For managed-service-orchestrator there are three issues currently

β€” Reply to this email directly, view it on GitHubhttps://github.com/eclipse-tractusx/sig-release/issues/82#issuecomment-1820527100, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AYFU5HAXT4GSP6IXIUES6QTYFRW4FAVCNFSM6AAAAAA5VHWXPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRQGUZDOMJQGA. You are receiving this because you were mentioned.Message ID: @.**@.>>

kelaja commented 11 months ago

no UX n/a

SebastianBezold commented 11 months ago

Release guildelines checked. App Release done: https://github.com/eclipse-tractusx/managed-service-orchestrator/releases/tag/v1.5.2

AppVersion 1.5.2 Chart version 1.5.3

vialkoje commented 10 months ago

expert approval granted for Architetcure-,Admin, user and interface doku