Closed birgitZF closed 9 months ago
PR https://github.com/eclipse-tractusx/sldt-semantic-models/pull/267 is merged now. Please revalidate the model and we can do the MS2 check further.
reference to address 3.0.0 is ok now, additionally I had to change some more fields according to ESS use case team. now the model should be final. hope no more changes will come up. validation with BAMM (check locally) was ok
@birgitZF @agg3fe and me checked you model. It seems there are problems in some regexes. We found the BPNs, the email and the longitude rule not validating agains the provided example value. For the BPN and email rule there where superfluous backslashes in the rule, which where easy to fix (fix provided in commit https://github.com/eclipse-tractusx/sldt-semantic-models/pull/263/commits/b686ce3f12ce5fc97ed08ba12e2bcd7a75dc6c05) but in the latitude and longitude rule there seem some conceptual problems. @agg3fe is investigating and can probably provide more details. Anyway, I think those rules need some adjustments.
@birgitZF @agg3fe and me checked you model. It seems there are problems in some regexes. We found the BPNs, the email and the longitude rule not validating agains the provided example value. For the BPN and email rule there where superfluous backslashes in the rule, which where easy to fix (fix provided in commit b686ce3) but in the latitude and longitude rule there seem some conceptual problems. @agg3fe is investigating and can probably provide more details. Anyway, I think those rules need some adjustments.
Checking the regex for 'LatitudeConstraint', i think you either need to adjust the regex pattern. If example value is correct then, regex should be something like: ^(\+|-)?(?:90(?:(?:\.0{1,6})?)|(?:[0-9]|[1-8][0-9])(?:(?:.[0-9]{1,7})?))$
For longitude, it should be: ^(\+|-)?(?:180(?:(?:\.0{1,6})?)|(?:[0-9]|[1-9][0-9]|1[0-7][0-9])(?:(?:.[0-9]{1,6})?))$
I think the example value for latitude was not correct, it should be -5.422077 instead of -5.4220777, anyway I will check with the implementation team first
@birgitZF with your fix to the example value the model is ok now
@birgitZF we should not forget about deprecating v1.0.0 of the model as soon as this one is released
@birgitZF we should not forget about deprecating v1.0.0 of the model as soon as this one is released
What does the process look like? Another issue / pull request or just change the "metadata.json" - file for the old version?
@birgitZF. we need to create a new issue to deprecatewith
can we put the model to MS3 review today?
yes, thanks, to put it to MS3 would be fine for me
shall I create the issue for the deprecation of the old version?
issue created [Model Deprecation]: essincident version 1.0.0 st to deprecate #282
Description
Update of essincident model to version 2.0.0. Changes due to discussions within Environment and Social Standards (ESS) team about the ESS incident process. Some changes were necessary to version 1.0.0. Issue #255 was created to organize the changes. #
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)