Closed catroest closed 7 months ago
@bs-jokri PR on behalf of Sabine and Johannes from SMC
@bs-jokri I don't know if Sabine wrote to you already. But please check this model. This model was renamed from Material for Recycling to Secondary Material Content and changed.
The checks for MS2 where done with the updated model provided with PR https://github.com/eclipse-tractusx/sldt-semantic-models/pull/291
@agg3fe will you have a look?
@catroest @johannsvarela there are still open review comments, who will resolve them? Otherwise we cannot assign MS2
@bs-jokri eventually followed by a deprecation request of the old one
@bs-jokri eventually followed by a deprecation request of the old one
@catroest could you link the deprecation request here?
from discussion property orderNumber will be checked if it should be marked optional.
@bs-jokri ready to merge, order number is now optional
Description
SMC Model includes new secondary characteristic attributes. Renamed from Material for Recycling.
Closes #261
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)