Closed johannsvarela closed 6 months ago
FYI @jonbckr @BenediktMuellerIML @jacewski-bosch
@johannsvarela do you want to add 'PartSiteInformationAsPlanned.ttl' also? If yes, then you have to create a separate Pull Request for this. we can have only one model (.ttl) file in one PR for new model.
@johannsvarela do you want to add 'PartSiteInformationAsPlanned.ttl' also? If yes, then you have to create a separate Pull Request for this. we can have only one model (.ttl) file in one PR for new model.
@agg3fe The second ttl-File (PartSiteInformationAsPlanned) contain the migration from BAMM to SAMM for the model. Since the PartSiteInformationAsPlanned will be set to 'deprecate', i don't know if its necessary to migrate to SAMM?
Otherwise i will integrate the SAMM-migration to the existing deprecation PR #454. Would it be fine for you?
@johannsvarela do you want to add 'PartSiteInformationAsPlanned.ttl' also? If yes, then you have to create a separate Pull Request for this. we can have only one model (.ttl) file in one PR for new model.
@agg3fe The second ttl-File (PartSiteInformationAsPlanned) contain the migration from BAMM to SAMM for the model. Since the PartSiteInformationAsPlanned will be set to 'deprecate', i don't know if its necessary to migrate to SAMM?
Otherwise i will integrate the SAMM-migration to the existing deprecation PR #454. Would it be fine for you?
If it is deprecated, then you don't need to migrate it from BAMM to SAMM. The separate PR is fine for me to set it to deprecate. you can remove the file from PR.
Please check my comments
@agg3fe The changes were implemented as you suggested! :-)
modeling_team
@agg3fe Jira-Issue to generate the testdata set for this model was created: https://jira.catena-x.net/browse/TDG-35
Based on the results / definition of the Industry Core, the part site information is also needed in the DTasBuilt context. Therefore a new aspect model was created, which contain the information of the sites of a part. The new model will be implemented as shared aspect model who will be integrated into the existing models SerialPart, Batch and JiS in further steps.
Closes #442
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)