Open hgo-ds opened 11 months ago
@hgo-ds Let me take a look into this.
Hi @hgo-ds if we chose from these options, then catenaxSiteId
would be correct one.
However, we had a discussion previously for not using word catenax for naming, and hence I would suggest to use only siteId
and not using word 'catenax'.
I would guess it's the second "catenaXSiteId". AFAIK, the trace guys (@johannsvarela, @jonbckr, @jacewski-bosch) are going to change those models soon. Maybe you have an opinion on it.
This model is deprecated, the information is now part of https://github.com/eclipse-tractusx/sldt-semantic-models/blob/main/io.catenax.part_as_planned/2.0.0/PartAsPlanned.ttl
@hgo-ds: please indicate if a HOTFIX is still necessary for this model
Thanks @jacewski-bosch for sharing the latest model.
There is no need for a HOTFIX.
In the meanwhile for Cofinity-X Trace-X we decided to be case insensitive on that property on the incoming site of IRS and the HTTP interface used by the frontend.
But still, a unique spelling would be recommended.
There are different spellings for the attribute
catenaXsiteId
in different places.catenaXsiteId
: https://github.com/eclipse-tractusx/sldt-semantic-models/blob/main/io.catenax.part_site_information_as_planned/1.0.0/gen/PartSiteInformationAsPlanned.jsoncatenaXSiteId
: https://github.com/eclipse-tractusx/sldt-semantic-models/blob/main/io.catenax.part_site_information_as_planned/1.0.0/PartSiteInformationAsPlanned.ttl#L78 \ https://eclipse-tractusx.github.io/docs-kits/kits/Traceability%20Kit/Software%20Development%20View/Specification%20Traceability%20Kit/#submodel-partsiteinformationasplanned-for-a-component-that-is-produced-at-the-given-sitecatenaxSiteId
: in Trace-X: https://github.com/eclipse-tractusx/traceability-foss/blob/main/tx-backend/src/main/java/org/eclipse/tractusx/traceability/assets/infrastructure/asplanned/model/AsPlannedInfo.java#L22 \ https://github.com/eclipse-tractusx/traceability-foss/blob/main/tx-backend/src/main/java/org/eclipse/tractusx/traceability/assets/application/asplanned/mapper/AssetAsPlannedFieldMapper.java#L35 \ https://github.com/eclipse-tractusx/traceability-foss/blob/main/tx-backend/src/main/java/org/eclipse/tractusx/traceability/assets/infrastructure/asplanned/model/AssetAsPlannedEntity.java#L61 \ https://github.com/eclipse-tractusx/traceability-foss/blob/main/tx-backend/testdata/CX_Testdata_MessagingTest_v0.0.10.json#L1465Which is the correct one?
Thanks for clarification.