Update: QualityTaks to 2.0.0

TorstenHirsch commented 5 months ago

Description

Converting the model to SAMM.

Added

integration of the shared BPNL trait
integration of shared e-Mail trait

Changed

changed all properties to optional except one unique identifier per entity
change property cxbpn cxBusinessPartnerNumber

Removed

Closes #416

MS2 Criteria

(to be filled out by PR reviewer)

[x] the model validates with the SAMM SDS SDK in the version specified in the Readme.md of this repository by the time of the MS2 check (e.g., 'java -jar samm-cli.jar aspect \<path-to-aspect-model> validate ). The SAMM CLI is available here and in GitHub
[x] use Camel-Case (e.g., "MyModelElement" or "TimeDifferenceGmtId", when in doubt follow https://google.github.io/styleguide/javaguide.html#s5.3-camel-case)
[x] the identifiers for all model elements start with a capital letter except for properties
[x] the identifier for properties starts with a small letter
[x] all model elements at least contain the fields "preferred name" and "description" in English language. The description must be comprehensible. It is not required to write full sentences but style should be consistent over the whole model
[x] Property and the referenced Characteristic should not have the same name
[x] the versioning in the URN follows semantic versioning, where minor version bumps are backwards compatible and major version bumps are not backwards compatible.
[x] use abbreviations only when necessary and if these are sufficiently common
[x] avoid redundant prefixes in property names (consider adding properties to an enclosing Entity or even adapt the namespace of the model elements, e.g., instead of having two properties DismantlerId and DismantlerName use an Entity Dismantler with the properties name and id or use a URN like io.catenax.dismantler:0.0.1)
[x] fields preferredName and description are not the same
[x] preferredName should be human readable and follow normal orthography (e.g., no camel case but normal word separation)
[x] name of aspect is singular except if it only has one property which is a Collection, List or Set. In theses cases, the aspect name is plural.
[x] units are referenced from the SAMM unit catalog whenever possible
[x] use constraints to make known constraints from the use case explicit in the aspect model
[x] when relying on external standards, they are referenced through a "see" element
[x] all properties with an simple type have an example value
[x] metadata.json exists with status "release"
[x] generated json schema validates against example json payload
[x] file RELEASE_NOTES.md exists and contains entries for proposed model changes
[x] all contributors to this model are mentioned in copyright header of model file

MS3 Criteria

(to be filled out by semantic modeling team before merge to main-branch)

[x] All required reviewers have approved this PR (see reviewers section)
[x] The new aspect (version) will be implemented by at least one data provider
[x] The new aspect (version) will be consumed by at least one data consumer
[x] There exists valid test data
[x] In case of a new (incompatible) major version to an existing version, a migration strategy has been developed
[x] The model has at least version '1.0.0'
[x] If a previous model exists, model deprecation has been checked for previous model
[x] The release date in the Release Note is set to the date of the MS3 approval

github-actions[bot] commented 5 months ago

Validation Report for io.catenax.quality_task/2.0.0/QualityTask.ttl

Input model is valid

github-actions[bot] commented 5 months ago

Validation Report for io.catenax.quality_task/2.0.0/QualityTask.ttl

Input model is valid

github-actions[bot] commented 5 months ago

Validation Report for io.catenax.quality_task/2.0.0/QualityTask.ttl

Input model is valid

github-actions[bot] commented 4 months ago

Validation Report for io.catenax.quality_task/2.0.0/QualityTasks.ttl

Input model is valid

github-actions[bot] commented 4 months ago

Validation Report for io.catenax.quality_task/2.0.0/QualityTasks.ttl

Input model is valid

github-actions[bot] commented 4 months ago

Validation Report for io.catenax.quality_task/2.0.0/QualityTasks.ttl

Input model is valid

github-actions[bot] commented 4 months ago

Validation Report for io.catenax.quality_task/2.0.0/QualityTask.ttl

Input model is valid

TorstenHirsch commented 4 months ago

modelling_team

TorstenHirsch commented 4 months ago

@agg3fe

agg3fe commented 4 months ago

@TorstenHirsch we have one clause: 'name of aspect is singular except if it only has one property which is a Collection, List or Set. In theses cases, the aspect name is plural.' In your case, I think. you have only one property in other models also, right? then We can keep the model name as plural and don't need to make it singular. For this model, for now we can keep it like this or if you want you can revert it to plural name if you want.

github-actions[bot] commented 4 months ago

Validation Report for io.catenax.quality_task/2.0.0/QualityTask.ttl

Input model is valid

TorstenHirsch commented 4 months ago

@TorstenHirsch we have one clause: 'name of aspect is singular except if it only has one property which is a Collection, List or Set. In theses cases, the aspect name is plural.' In your case, I think. you have only one property in other models also, right? then We can keep the model name as plural and don't need to make it singular. For this model, for now we can keep it like this or if you want you can revert it to plural name if you want.

@agg3fe Let's keep the model name qualityTask - if possible

github-actions[bot] commented 4 months ago

Validation Report for io.catenax.quality_task/2.0.0/QualityTask.ttl

Input model is valid

github-actions[bot] commented 4 months ago

Validation Report for io.catenax.quality_task/2.0.0/QualityTask.ttl

Input model is valid

agg3fe commented 4 months ago

@TorstenHirsch please fix one typo, then we are good for MS2.

TorstenHirsch commented 4 months ago

@TorstenHirsch please fix one typo, then we are good for MS2.

Done - let's go for MS2 :-) @agg2fe modelling_team

github-actions[bot] commented 4 months ago

Validation Report for io.catenax.quality_task/2.0.0/QualityTask.ttl

Input model is valid

github-actions[bot] commented 4 months ago

Validation Report for io.catenax.quality_task/2.0.0/QualityTask.ttl

Input model is valid

github-actions[bot] commented 4 months ago

eclipse-tractusx / sldt-semantic-models