search

eclipse-tractusx / sldt-semantic-models

sldt-semantic-models
Creative Commons Attribution 4.0 International
29 stars 44 forks source link

[Model Issue]: QualityTaskAttachment incorrect example value #598

Closed agg3fe closed 7 months ago

agg3fe commented 7 months ago

Issue Description

Example value for QualityTaskAttachment model property 'unit' is not correct. current value: degreeCelsiusPerHour correct value: unit:degreeCelsiusPerHour"^^samm:curie

agg3fe commented 7 months ago

@JulianSchererZF Could you please check this request. The example value needs to be corrected in model. I have specified the correct value also. New version of the model would be required.

JulianSchererZF commented 7 months ago

@agg3fe, I will have a look into it ASAP

JulianSchererZF commented 7 months ago

@JulianSchererZF Could you please check this request. The example value needs to be corrected in model. I have specified the correct value also. New version of the model would be required.

@agg3fe I modified the model as you mentioned. Do we need a Version 2.0.0 here or would be a version 1.0.1 possible?

agg3fe commented 7 months ago

@JulianSchererZF Could you please check this request. The example value needs to be corrected in model. I have specified the correct value also. New version of the model would be required.

@agg3fe I modified the model as you mentioned. Do we need a Version 2.0.0 here or would be a version 1.0.1 possible?

Version 2.0.0 would be required as this is major change from bamm to samm also.

JulianSchererZF commented 7 months ago

@JulianSchererZF Could you please check this request. The example value needs to be corrected in model. I have specified the correct value also. New version of the model would be required.

@agg3fe I modified the model as you mentioned. Do we need a Version 2.0.0 here or would be a version 1.0.1 possible?

Version 2.0.0 would be required as this is major change from bamm to samm also.

It was already modeled in SAMM so it would be only the wrong example value what has changed

agg3fe commented 7 months ago

@JulianSchererZF Could you please check this request. The example value needs to be corrected in model. I have specified the correct value also. New version of the model would be required.

@agg3fe I modified the model as you mentioned. Do we need a Version 2.0.0 here or would be a version 1.0.1 possible?

Version 2.0.0 would be required as this is major change from bamm to samm also.

It was already modeled in SAMM so it would be only the wrong example value what has changed

Yes. still it would need major version as samm migration will be there from 2.0.0 to 2.1.0