Closed dhiren-singh-007 closed 1 month ago
Hi @dhiren-singh-007 thank you for the fix! Just letting you know that the review will take a couple of days as @Phil91 is on vacation this week and I'd like him to review as well.
I assume the config should also be added to the appsettings as we want maintain all config there as well, but let's wait for @Phil91 feedback
@evegufy No problem . Thanks for the update . Agree appsettings should be updated , I will wait for @Phil91 feedback.
Unfortunately you merged the wrong branch (main instead of the release branch): could you please rebase to release branch so that only you commits are shown in the diff?
Thanks @evegufy , Yeah this happens after syncing the Fork from Github UI . It looks like I should use commands to rebase .
oh i got it now , So in forked repo Github UI shows a update branch option . So i thought it just sync the changes of the branch which exist only on upstream but it actually merged the main from upstream . Let me try to fix it else i will create a new PR
Description
Added environment value for PortalSettings in
charts/ssi-credential-issuer/templates/cronjob-expiry-app.yaml
fixes #195 closes #195Why
To run this project PortalSettings are required
Issue
Issue #195
Checklist
Please delete options that are not relevant.