fix(cronjob expiry): added the missing environment value for portal

eclipse-tractusx / ssi-credential-issuer

SSI Credential Issuer

Apache License 2.0

2 stars 9 forks source link

fix(cronjob expiry): added the missing environment value for portal #196

Closed dhiren-singh-007 closed 1 month ago

dhiren-singh-007 commented 2 months ago

Description

Added environment value for PortalSettings in charts/ssi-credential-issuer/templates/cronjob-expiry-app.yaml fixes #195 closes #195

Why

To run this project PortalSettings are required

Issue

Issue #195

Checklist

Please delete options that are not relevant.

[x] I have followed the contributing guidelines
[x] I have performed a self-review of my own code
[x] I have successfully tested my changes locally

evegufy commented 2 months ago

Hi @dhiren-singh-007 thank you for the fix! Just letting you know that the review will take a couple of days as @Phil91 is on vacation this week and I'd like him to review as well.

I assume the config should also be added to the appsettings as we want maintain all config there as well, but let's wait for @Phil91 feedback

dhiren-singh-007 commented 2 months ago

@evegufy No problem . Thanks for the update . Agree appsettings should be updated , I will wait for @Phil91 feedback.

dhiren-singh-007 commented 1 month ago

Unfortunately you merged the wrong branch (main instead of the release branch): could you please rebase to release branch so that only you commits are shown in the diff?

Thanks @evegufy , Yeah this happens after syncing the Fork from Github UI . It looks like I should use commands to rebase .

dhiren-singh-007 commented 1 month ago

oh i got it now , So in forked repo Github UI shows a update branch option . So i thought it just sync the changes of the branch which exist only on upstream but it actually merged the main from upstream . Let me try to fix it else i will create a new PR