eclipse-tractusx / ssi-credential-issuer

SSI Credential Issuer
Apache License 2.0
4 stars 10 forks source link

Credential has wrong status after approval #285

Closed Phil91 closed 2 weeks ago

Phil91 commented 1 month ago

Current Behavior

When approving a framework credential it is directly set to active, even if it isn't existing in the wallet.

Expected Behavior

The credential should only be active if it is existing in the wallet

Steps To Reproduce

Create a credential, approve the credential with a not running process worker. The credential is set to active

evegufy commented 1 month ago

@Phil91 just wondering, did you forget to open a PR for https://github.com/eclipse-tractusx/ssi-credential-issuer/commit/9b90e2f01ad92f13edbe091f3f48e26c5c7e484e? :)

Phil91 commented 1 month ago

@Phil91 just wondering, did you forget to open a PR for 9b90e2f? :)

I actually did - sorry, it's created now: https://github.com/eclipse-tractusx/ssi-credential-issuer/pull/286

evegufy commented 2 weeks ago

we noticed that the change, should be accompanied by some usability improvements: