eclipse-tractusx / traceability-foss

https://eclipse-tractusx.github.io/traceability-foss/docs/
Apache License 2.0
11 stars 23 forks source link

Implementation of JSON schemas as aspect models #444

Closed ds-jleyh closed 7 months ago

ds-jleyh commented 10 months ago

As a TraceX application, I want to have an easy adaptable support of new aspect models so that I can implement new aspect model versions during a transition phase of versions (described in TRACE-1232)

Hints / Details

The concept for Trace-X can be found here: https://confluence.catena-x.net/display/BDPQ/%5BTRACEFOSS-2773%5D+Downward-Compatibility+of+Aspect+models

Acceptance Criteria

Out of Scope

mkanal commented 8 months ago

@jzbmw team recommendation is to have a concept in advance to provide a suitable solution for this backward compatibility

ds-mwesener commented 7 months ago

Implementation allows us now to simply replace the schema file with the latest version to add it to the supported aspect models. If the schema has breaking changes we only need to adapt the mapping logic on the specific aspect model which includes the breaking changes. All others are not affected anymore.

ds-mwesener commented 7 months ago

Hi @ds-alexander-bulgakov please test. Is deployed on e2e environments.

ds-alexander-bulgakov commented 7 months ago

No issues could be found during testing on e2e-a. Assets are consumed correctly, notification flow is working as well. Testing with @ds-ext-sceronik of jsonschema2pojo:generate by modifications of schema files and POJO generations based on the changes were successful as well. Ticket is ready for PO-review, FYI @jzbmw.