Duplicated child elements on cucumber test run

eclipse-tractusx / traceability-foss

https://eclipse-tractusx.github.io/traceability-foss/docs/

Apache License 2.0

11 stars 23 forks source link

Duplicated child elements on cucumber test run #516

Closed ds-ashanmugavel closed 9 months ago

ds-ashanmugavel commented 11 months ago

Environment

(?) E2E-B

Prerequisites

Clean e2e-b environment
uploaded testdata
registry reloaded

Steps to reproduce

run cucumber tests few times

Current behavior

After running cucumber tests few times' child elements for asset id "urn:uuid:7eeeac86-7b69-444d-81e6-655d0f1513bd" are duplicated in database to that point that when requesting assets, pod is restarting without of memory exception.

Expected behavior

there are no duplications of child element for given asset ID after running cucumber tests

jzbmw commented 10 months ago

https://jira.catena-x.net/browse/TRACEFOSS-2636

ds-mwesener commented 10 months ago

Hi @ds-ext-sceronik do you remember if this has been fixed already?

ds-ext-sceronik commented 10 months ago

@ds-mwesener I dont know to be honest. quick test to verify is to run integration tests once and then again and lookup database orget all assets by the endpoint and check if there are duplicate child elements in the list of child assets.

ds-mwesener commented 10 months ago

https://jira.catena-x.net/browse/TRACEFOSS-3115:

Error on: Then I check, if quality alert has proper values after "approve" TRACEFOSS-1863 [BE] Check correct processing of CLOSURE of quality alerts

Error on: Then I check, if quality investigation has proper values after "approve" TRACEFOSS-1861 [BE] Check correct processing of CLOSURE of quality investigation

Error on: Then I check, if quality alert has proper values after "approve" https://jira.catena-x.net/browse/TRACEFOSS-1545 [BE] Check correct processing of DECLINATION of quality alerts Error on: When I acknowledge quality investigation -> 504 instead of 204 TRACEFOSS-1222 [BE] Check correct processing of ACCEPTANCE of quality investigation

Then I check, if quality investigation has proper values Then I check, if quality investigation has proper values (after acknowledge -> timeout) Then I check, if quality investigation has proper values (after acknowledge -> timeout)

ds-mwesener commented 10 months ago

Outcome: I have executed the e2e tests multiple times sequentially and in parallel. It turned out that the initial error with duplicated child elements is already solved. Other than that our E2E Tests are often failing because of edc exceptions. Specially if we send multiple negotiation requests to the edc sometimes it can not handle the request and throws an exception.

As currently trace-x does not store the error into the database, the e2e test is not able to retry sending the notification. Therefore I created a follow up story: https://github.com/eclipse-tractusx/traceability-foss/issues/606

ds-mwesener commented 10 months ago

Hi @ds-alexander-bulgakov please have a short review. Thanks

ds-alexander-bulgakov commented 10 months ago

Hi @ds-mwesener, after on the sender side (e2e-a) no duplicate childs could be found but on the receiver (e2e-b) there are too much:

The amount did not change after several executions of our cucumber-tests but still there are too much childs for one asset. Could you please have a look? Thank you!

ds-mwesener commented 9 months ago

The references of the as_planned entities were incorrectly set. Those have been removed. Issue is not reproducable anymore. Currently waiting for pull request review.

ds-mwesener commented 9 months ago

Hi @ds-alexander-bulgakov issue has been merged and deployed on e2e-a. FYI

ds-alexander-bulgakov commented 9 months ago

Hi Max, the childs are not created anymore, therefore this ticket is ready for PO-review. FYI @jzbmw. Thank you!