search

eclipse-tractusx / traceability-foss

https://eclipse-tractusx.github.io/traceability-foss/docs/
Apache License 2.0
11 stars 22 forks source link

Migrate to the newest IRS version #823

Closed ds-lcapellino closed 5 months ago

ds-lcapellino commented 5 months ago

As Developer, I want to migrate to the newest IRS version, so that I can also migrate to the newest Registry version for Release 24.05.

Links

Hints / Details

-irs-helm version must be upgraded from 6.9.1 to 6.18.0

Acceptance Criteria

Out of Scope

mkanal commented 5 months ago

@jzbmw as this blocks #636 I have added this to the sprint scope.

ds-lcapellino commented 5 months ago

Because of the IRS changes in 4.8.0: Registering a job - aspects array is now accepting full urn of aspect model instead of name only, eg. 'urn:bamm:io.catenax.single_level_bom_as_built:2.0.0#SingleLevelBomAsBuilt' instead 'SingleLevelBomAsBuilt'. #439 We have to downgrade to urn:bamm:io.catenax.single_level_bom_as_built:1.0.0#SingleLevelBomAsBuilt. IRS can not process such aspects, becuase this version is not present in the semantic hub.

ds-lcapellino commented 5 months ago
ds-mwesener commented 5 months ago

Currently the e2e tests failing because of the implementation of the story. The e2e tests using a global asset with a relation to urn:bamm:io.catenax.single_level_usage_as_built:2.0.0#SingleLevelUsageAsBuilt

See log on trace-x b when trying to resolve the relationship object which is needed for a successfull notification within the e2e tests.

org.springframework.web.client.HttpClientErrorException$BadRequest: 400 null: "{"statusCode":"BAD_REQUEST","error":"Aspects did not match the available aspects: '[urn:bamm:io.catenax.single_level_usage_as_built:2.0.0#SingleLevelUsageAsBuilt]'","messages":null}"

@ds-lcapellino please find an efficient way how we can deal with this. E2E Tests red is not acceptable.

Thank you

ds-lcapellino commented 5 months ago

This PR: https://github.com/catenax-ng/tx-traceability-foss/pull/1157 will downgrade SingeLevelUsageAsBuilt to 1.0.0. Because 2.0.0 is not yet in the Semantic Hub.

ds-mwesener commented 5 months ago

Hi @ds-lcapellino please create a new issue which will also adapt our data import controller. Currently it is accepting also the 2.0.0.

ds-crehm commented 5 months ago

Not possible to test. E2E tests are working again. Ready for review.