🧐🤚[UUX] Improve user feedback after triggering notification actions

ds-crehm commented 4 months ago

Hints / Details

R24.05 UUX feedback:

-- blocking -- Upon clicking approval for just created quality investition, no indication of processing is given Hitting Details still shows queued view, Only a while later info at top right of page that approval processed Table view however, does not get automatically updated / refreshed

Acceptance Criteria

[x] After async action from table (approve, acknowledge, accept, decline, cancel, close) has been triggered spinner is shown in status column and action menu will still show the same actions but these are disabled with a tooltip that progress is ongoing. User can still open detail view
[x] In detail view after async action on while it is already in progress (same as above) the action buttons are disabled with a proper tooltip (ongoing process)
[x] Loading spinner will replace the status element in the table / detail view
[x] User can navigate back from detail view to the table and will see the spinner on the status column as long as it is in progress
[x] Table size will not change when spinner appears
[x] Loading spinner shows a tooltip with a proper message
[x] User is able to trigger async actions on another notifications (also if there is progress ongoing on a different one)

Out of scope

[ ] Parallel sessions with different browser show the loading spinner.

mkanal commented 3 months ago

Please add clear context why DISCUSSION NEEDED was added. @ds-crehm

ds-mmaul commented 2 months ago

✅ After async action from table (approve, acknowledge, accept, decline, cancel, close) has been triggered spinner is shown in status column and action menu will still show the same actions but these are disabled with a tooltip that progress is ongoing. User can still open detail view

✅In detail view after async action on while it is already in progress (same as above) the action buttons are disabled with a proper tooltip (ongoing process)

✅Loading spinner will replace the status element in the table / detail view

✅User can navigate back from detail view to the table and will see the spinner on the status column as long as it is in progress

✅ (Zeilenhöhe) Table size will not change when spinner appears

✅Loading spinner shows a tooltip with a proper message

✅ User is able to trigger async actions on another notifications (also if there is progress ongoing on a different one)

✅ try again supports the upper points

ds-crehm commented 2 months ago

Tested on E2E. Works very nicely. This kind of feedback is great and the implementation is done well. All points were successfully tested.

One small issue: When switching between table view and detail view, the spinner is visible, but after the status change the status shown is still the old one. Only after manually refreshing the page the status is updated: Here I acknowledged the notification in the table view and then switched to the detail view while it was still in progress. Then I get the success message but the status shown is still the old one.

ds-crehm commented 2 months ago

Issue from my last comment is now fixed (tested on e2e). Status is now correctly updated after switching views during status update.

Ready for review.

mkanal commented 2 months ago

https://github.com/eclipse-tractusx/traceability-foss/issues/1227 https://github.com/eclipse-tractusx/traceability-foss/issues/1228 Loading Supplier Table in Details View takes more than 10 seconds !!!

mkanal commented 2 months ago

@ds-crehm Kindly ask to retest the story.

ds-crehm commented 2 months ago

Tested again on E2E: LGTM You already created the bug tickets. So those issues are addressed.

The time it took to load was because of the amount of data in the application database at the time. After an application reset the time is more reasonable again. It was not caused by the implementation of this ticket, so it can be moved to review again.

mkanal commented 2 months ago

Retest after application is running for some time and more than initial data are provided.

mkanal commented 2 months ago

LGFM PO acceptance in behalf of @jzbmw https://github.com/eclipse-tractusx/traceability-foss/issues/1227 https://github.com/eclipse-tractusx/traceability-foss/issues/1228

eclipse-tractusx / traceability-foss