search

eclipse-tractusx / tractus-x-umbrella

Where all Tractus-X comes together
Apache License 2.0
12 stars 24 forks source link

feat: add BPDM chart to umbrella chart #108

Closed nicoprow closed 4 months ago

nicoprow commented 4 months ago

Description

This pull request adds the BPDM chart for Catena-X 24.05 to the umbrella chart.

The umbrella chart sets up the central Pool component and the necessary components for the golden record process. Also, it creates and configures a Gate for the Portal with which to share business partner data to the golden record process.

Please note that a hotfix was needed in order to use the BPDM chart as a dependency: 5.0.3.

To be honest the need for this hotfix still confuses me. The faulty configuration for 5.0.2 really only takes effect if you use this chart as a dependency but not stand-alone. Maybe someone with better insight into helm can exaplain this. In any case, the Chart is working now as a dependency.

The BPDM component will successfully install with the following command from the root directory:

helm install  \
 --set centralidp.enabled=true,bpdm.enabled=true \
 --namespace umbrella \
 --generate-name \
 --create-namespace \
 charts/umbrella

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

nicoprow commented 4 months ago

Hi @nicoprow great that you opened the PR!

Does it contain the missing config discussed here? eclipse-tractusx/portal-backend#819 (comment)

I tested and encounter the following issues with the database connection: logs-from-bpdm-gate-in-umbrella-bpdm-gate-85b9fb65bd-hqkqh.log logs-from-bpdm-cleaning-service-dummy-in-umbrella-bpdm-cleaning-service-dummy-9969db5cb-qjb6f.log logs-from-bpdm-pool-in-umbrella-bpdm-pool-f546b5f99-b9t8s.log

There's also the PR #106 from @gomezbc who did the awesome work of providing his configuration of BPDM 5.0.2 version and the database connection issue seems to already addressed there, but currently we're facing 401 errors there which might be due to this missing configuration...

Could you please align with @gomezbc to bring the best of both of your PRs together?

As the BPDM 5.0.3 version is for R24.05 and main is still set on R24.03 it would be great if you could redirect your PR to the upgrade branch for 24.05 https://github.com/eclipse-tractusx/tractus-x-umbrella/tree/upgrade/24.05

I guess these logs happened before the BPDM-Postgres was finished setting up. The helm install like stated above works. The services just need the centralidp and postgres to be running and after that they stop crashing.

I will close this and make the target the update 24.05 branch. I will also try to get in touch @gomezbc for aligning, as he seems to have better grasp of the portal config needed.